[#35138] - [4] Remove PHP from a plain text file
- Fixed in Code Base
- 9 Sep 2021
- Medium
- Build: 4.0-dev
- # 35138
- Diff
- PhilETaylor:patch-221
User tests: Successful: Unsuccessful:
Code review.
There is no point having a PHP comment in a file without a PHP extension, it will never be parsed and doesn't ever run.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35138.
I disagree. There is no copyright statement in README.md README.txt
There is no need for a copyright statement in this file. Just like there is no need for yet another LICENSE.txt file in the installation that you put there.
agree to disagree - really not worth spending any time on it
so yet another PR destined to be left open for another decade. Pathetic.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35138.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35138.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35138.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-09 17:11:15 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
Removed: ? |
||
Thanks!
No point indeed for it being inside php. But deleting the copyright itself is not a solution. That has to remain.