I have tested this item ? unsuccessfully on 67617a9

doesnt remove the folder

doesnt remove the folder

I never said it removed the folder. This PR doesnt remove the folder on sites that already have the folder in their installation folder.

This PR meets its aims as evidenced by the missing folder in the correct branch. https://github.com/PhilETaylor/joomla-cms/tree/removesessionsfolder/installation

There is no need to "clean up" existing folders like when we deleted folders in Joomla CMS elsewhere, because this is in the installation folder - and therefore is deleted on installation anyway and should not exist on a live site!

The installation folder is indeed not handled by the files and folders deletion by purpose: https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php#L63-L75

The installation folder is indeed not handled by the files and folders deletion by purpose:

Therefore this PR is correct and marking it with a an unsuccessful test is incorrect.

The installation folder is indeed not handled by the files and folders deletion by purpose:

Therefore this PR is correct and marking it with a an unsuccessful test is incorrect.

@PhilETaylor I agree. @brianteeman could you revert your unsuccessful test? Thanks in advance.

This formerly was hardcoded here 14c78cf#diff-b000eaf18097ff802a6ad7bd96bd84543e8e232b2ded62dec482d0641d552defR56 . I think we've removed it when we moved here #18896 and we just use php temp directory now?

I think we've removed it when we moved here #18896 and we just use php temp directory now?

Further supporting the aims of this PR as being perfectly valid

This formerly was hardcoded here 14c78cf#diff-b000eaf18097ff802a6ad7bd96bd84543e8e232b2ded62dec482d0641d552defR56 . I think we've removed it when we moved here #18896 and we just use php temp directory now?

Yes, seems so.

I have tested this item ✅ successfully on 67617a9

The folder seems not to be used, at least I could not see it being accessed anyhow when making a new installation of J4.

When making a new installation where the folder has been removed before, the installation works well and there is no PHP error or warning logged.

Since the folder is below the installation folder, there is not need to care for removal on update.

Thanks!