[#35049] - [4.0] Editors have only the resolved url for images
- Fixed in Code Base
- 12 Sep 2021
- Medium
- Build: 4.0-dev
- # 35049
- Diff
- dgrammatiko:4.0-dev-external-adapters
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- This PR adds a
data-paththat reflects to the unresolved URI for an image - It affects only images inserted into an editor
- Allows plugins to work with external adapters (now it's impossible to get from the resolved URL to the adapter, path, etc)
Testing Instructions
Apply the patch
run npm install
Create a new article and try to insert an image into the editor
Switch to code view and observe that there is a data-path attribute. Image tag looks like: <img src="images/joomla_black.png" width="225" height="50" loading="lazy" data-path="local-images:/joomla_black.png" />
Actual result BEFORE applying this Pull Request
No way to get to the adapter/path
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge I will be extremelly thankful if this could be patched before GA
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
data-path is added. Path works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35049.
@joomla/security would appreciate a quick review here. I can't easily think of a way this could be exploited but just in case.
I have tested this item
Works as described.
Regarding security implications: I don't see any, but I might be missing something.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35049.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35049.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-12 09:05:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
Does this PR solve issue #35054 or helps solving it?