[#35048] - [4.0] Let build tools always start clean
- Closed
- 17 Aug 2021
- Medium
- Build: 4.0-dev
- # 35048
- Diff
- dgrammatiko:4.0-dev-build-tools-rimraf-folders
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Clean all the Joomla core media folders each time that
npm installis called
Testing Instructions
Before applying the patch make a backup of your current media folder
Apply the patch
Run npm install
Compare the backup folder with the current media
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge this can wait till 4.0 is released
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Considering your previous comment is it safe to remove all of vendor and should it not be vendor\xxxxx
Yeah, probably I should target only the vendor folders that Joomla delivers. That said the existing code already discards the vendor folder, so I guess I need to fine-tune that part
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048.
I have tested this item
Patch works. On loding the article the description gets truncated to 160 characters.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048.
@richard67 My browser had some hick ups. Sorry for the confusion.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048.
@dgrammatiko how can I verify that the patch works? Should there be a difference between the backed up folder and the newly generated?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35048.
how can I verify that the patch works? Should there be a difference between the backed up folder
There should be identical (assuming that the backup didn't had .gz files, if it did you need to run the npm run compress iirc)
This PR is not needed urgently so I will switch it to draft and we can check it back after the GA
@RickR2H @richard67 I've opened a new PR with the code from this one plus a replacement of a node package for the watch functionality. Please test #35198
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-17 17:27:24 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
?
Removed: ? |
||
Considering your previous comment is it safe to remove all of
vendorand should it not bevendor\xxxxx