Thanks for the upstream PR to address the empty area

when you save the article with the character count greater than the maximum allowed it will be saved truncated

when you save the article with the character count greater than the maximum allowed it will be saved truncated

I think by editing the db directly we can replicate the issue (eg j3 article with more than 160chrs in the description). But after editing the article in the backend then the description will be <= 160chrs

Tested this PR and it doesnt work :(

Tested this PR and it doesnt work :(

Delete the media folder and run again npm install

weird. I thought that npm i already did the media folder bit

anyway works now

ah - see the problem (i think)

Before this PR the folder media/vendor/short-and-sweet/js had three files .js, .min.js, .min,.js.gz

The npm i script only copies files to the media folder it doesnt remove existing files

The npm i script only copies files to the media folder it doesnt remove existing files

Maybe the build tools should remove any existing .gz files, will do a PR later

or just remove everything?

or just remove everything?

I didn't do that on purpose, eg someone tries to test a PR but also has installed some 3rd PT extension. In such case, testing will require uninstalling and reinstalling the extension(s), since the media assets will be deleted, and thus making the process significantly slower.

The real problem in this specific example is that an existing install of rc5 will have the three files in it but for some reason when you run the install script now now only one file is created. When someone upgrades from rc5 to the final release wouldn't that cause problems

but for some reason when you run the install script now now only one file is created.

I have 2 files and once you run the compress part will get also the .gz

@brianteeman can you retest deleting the media folder and re run npm i? You should now get 2 files

@brianteeman should be ok now with 01e89f8

I have tested this item ✅ successfully on 01e89f8

Patch works. On loding the article the description gets truncated to 160 characters.

I have tested this item ✅ successfully on 01e89f8

RTC

@dgrammatiko can you fix conflicts here and @brianteeman you able to test this on windows?

@wilsonge #35039 (comment) its fine

@brianteeman but then dimitris fixed the two files thing. which you gave a negative test on and he attempted a second fix on (see #35039 (comment))

ah sorry. taking another look

ok now

I have tested this item ✅ successfully on 01e89f8

Amazing. Thanks @dgrammatiko just conflicts and I'll get this in then

Thanks!