NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
2 Aug 2021

Pull Request for Issue # .

Summary of Changes

  • Moved the file menu-metismenu.es6.js from build/media_source/templates/cassiopeia/js/mod_menu/ to build/media_source/templates/site/cassiopeia/js/mod_menu/ (there is a site missing there)
  • Adjust the layout to use the correct path

Testing Instructions

Enable the dropdown layout for the frontend menu. Check that the metismenu script is loaded

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge this is kinda important for the Child templates
@richard67 I think you need to add the old paths to the files removed

avatar dgrammatiko dgrammatiko - open - 2 Aug 2021
avatar dgrammatiko dgrammatiko - change - 2 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2021
Category JavaScript Repository NPM Change Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 2 Aug 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 2 Aug 2021

Why?

This is not Cassiopeia specific

avatar dgrammatiko
dgrammatiko - comment - 2 Aug 2021

Why?

The child templates are already configured (check the HTML helper file for the overrides) to look at the folders media/templates/site and media/templates/administrator depending on if the template is front end or back end. The current path was picked out of the blue, it doesn't follow any rules...

avatar brianteeman
brianteeman - comment - 2 Aug 2021

Sorry was reading on my phone. Ignore my comment

avatar wilsonge
wilsonge - comment - 2 Aug 2021

OK Let's get a quick test but this looks good to me

avatar RickR2H RickR2H - test_item - 2 Aug 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 2 Aug 2021

I have tested this item successfully on fe15fec

Path is correct and script is loaded after the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

avatar jwaisner jwaisner - test_item - 2 Aug 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 2 Aug 2021

I have tested this item successfully on fe15fec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

avatar jwaisner jwaisner - change - 2 Aug 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 2 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35024.

avatar wilsonge wilsonge - close - 4 Aug 2021
avatar wilsonge wilsonge - merge - 4 Aug 2021
avatar wilsonge wilsonge - change - 4 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-04 21:43:30
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 4 Aug 2021

Thanks!

Add a Comment

Login with GitHub to post a comment