? ? Pending

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
2 Aug 2021

Pull Request for Issue #35015 .

Summary of Changes

Added str_replace() to change \ to /.
Looks like only the str_replace() at line 189 maybe essential but included one at line 175 for consistency and clarity.

Testing Instructions

Use a MS Windows hosted test site (may not be a problem on Linux sites).
Install this library:
lib_bftest1.zip

Actual result BEFORE applying this Pull Request

The library installed correctly AND appears in the Extensions:Discover listing.
Can then be installed again from there - get 2 records in the extensions table!

Need to uninstall both before testing the patch.

Expected result AFTER applying this Pull Request

The library installed correctly and does not appear in the Extensions:Discover listing.

Documentation Changes Required

docs.joomla.org/Manifest_files
Has been updated with J4.0 library related information since originally written ...

Current documentation on manifest files for libraries is rather limited (no longer true!).
https://docs.joomla.org/Manifest_files

More information on this can be found elsewhere, such as ...
https://www.joomlashack.com/blog/how-tos/development/how-to-package-joomla-libraries/ (see comments at end)
https://joomla.stackexchange.com/questions/13681/manifest-file-format-for-installing-a-library-package

This pull request and previous pull request #34910 appear to complete an 'almost working' undocumented feature, namely ...

What is not immediately obvious is that you can include a slash (/) in the folder name, so you can put all your company libraries into JPATH_SITE/libraries/mycompany using this:

<libraryname>mycompany/mydosomething</libraryname>
<libraryname>mycompany/mydosomethingelse</libraryname>
avatar BrainforgeUK BrainforgeUK - open - 2 Aug 2021
avatar BrainforgeUK BrainforgeUK - change - 2 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2021
Category Administration com_installer
avatar RickR2H RickR2H - test_item - 2 Aug 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 2 Aug 2021

I have tested this item successfully on 3765cb8

Tested on a WAMP server and could reproduce the issue. The patch fixed the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35023.

avatar brianteeman
brianteeman - comment - 2 Aug 2021

Please fix the code style issues
https://ci.joomla.org/joomla/joomla-cms/46322/1/6

avatar BrainforgeUK BrainforgeUK - change - 2 Aug 2021
Labels Added: ?
avatar BrainforgeUK
BrainforgeUK - comment - 3 Aug 2021

Code style changes made - issue resolved?

avatar BrainforgeUK BrainforgeUK - change - 3 Aug 2021
The description was changed
avatar BrainforgeUK BrainforgeUK - edited - 3 Aug 2021
avatar BrainforgeUK BrainforgeUK - change - 5 Aug 2021
The description was changed
avatar BrainforgeUK BrainforgeUK - edited - 5 Aug 2021
avatar Quy Quy - test_item - 6 Aug 2021 - Tested successfully
avatar Quy
Quy - comment - 6 Aug 2021

I have tested this item successfully on 07439b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35023.

avatar Quy Quy - change - 6 Aug 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35023.

avatar richard67 richard67 - alter_testresult - 7 Aug 2021 - RickR2H: Tested successfully
avatar BrainforgeUK BrainforgeUK - change - 16 Aug 2021
Labels Added: ? ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Administration com_installer Administration com_installer Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Administration com_installer Libraries Administration com_installer
avatar BrainforgeUK BrainforgeUK - change - 21 Aug 2021
Labels Added: ? ?
Removed: ? ?
avatar wilsonge wilsonge - close - 16 Oct 2021
avatar wilsonge wilsonge - merge - 16 Oct 2021
avatar wilsonge wilsonge - change - 16 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-16 19:43:23
Closed_By wilsonge
Labels Added: ? ?
Removed: ? ?
avatar wilsonge
wilsonge - comment - 16 Oct 2021

Thanks!

Add a Comment

Login with GitHub to post a comment