[#34961] - Add new logging category and add sample log entry for it
- Fixed in Code Base
- 16 Aug 2021
- Medium
- Build: 4.0-dev
- # 34961
- Diff
- wilsonge:logging_updates
User tests: Successful: Unsuccessful:
Pull Request for Issue #34908 .
Summary of Changes
Add new category for logging system errors within Joomla Core to file. This is something we should expand with additional errors we want don't want to show to end users of the site (in whatever client - remember editors in the backend may not be fully trusted users!)
Testing Instructions
Please follow #34908
Alternatively - in your database go to the template styles column and change the template name from atum to an alternative such as atum2.
Actual result BEFORE applying this Pull Request
Error shown on screen
Expected result AFTER applying this Pull Request
Error logged to file (by default JROOT/administrator/logs/joomla_core_errors.php). File name can be debated to death obviously.
Documentation Changes Required
Yes - we should include this file in documentation on how to debug core - even if it's just a one off!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to discussion in reviews above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
| Labels |
Added:
?
?
Removed: ? |
||
I have tested this item
After update from 3.10-dev to the patched package created by drone for this PR, the error alert about the missing template is not shown anymore in backend.
Instead of this, the error is logged into file administrator/logs/joomla_core_errors.php:
#<?php die('Forbidden.'); ?>
#Date: 2021-08-16 21:14:28 UTC
#Software: Joomla! 4.0.0-rc7-dev+pr.34961 Development [ Mañana ] 10-August-2021 23:02 GMT
#Fields: datetime priority clientip category message
2021-08-16T21:14:28+00:00 ERROR 192.168.98.1 system The template for this display is not available.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
I have tested this item
by review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-16 21:43:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? ? |
||
I have tested this item✅ successfully on 07cdacc
Tested successfully in RC6-dev of 28 July using PHP 8.0.8 in Wampserver 3.2.5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34961.