[#34962] - [4.0] Don't deliver old images in J4
- Fixed in Code Base
- 2 Aug 2021
- Medium
- Build: 4.0-dev
- # 34962
- Diff
- chmst:old-images-remove
User tests: Successful: Unsuccessful:
Pull Request for Issue #34931
Summary of Changes
Following images are old and in J4 replaced by icons. They should not be delivered in J4.
The old images should NOT be deleted in updated versions where they could be in use by older extensions.
mooRainbow
arrow.png
arrow_rtl.png
blank.png
calendar.png
checked_out.png
edit.png
edit_unpublished.png
emailButton.png
icon_error.gif
icon-16-logout.png
indent.png
indent1.png
indent2.png
indent3.png
indent4.png
indent5.png
jquery.minicolors.png
livemarks.png
livemarks-rtl.png
mootree.gif
mootree_loader.gif
new.png
no_indent.png
pdf_button.png
printButton.png
rating_star.png
rating_star_blank.png
sort_asc.png
sort_desc.png
sort_none.png
sort0.png
sort1.png
tooltip.png
weblink.png
mooRainbow/blank.gif
mooRainbow/moor_arrows.gif
mooRainbow/moor_slider.gif
mooRainbow/moor_cursor.gif
mooRainbow/moor_woverlay.png
Testing Instructions
Actual result BEFORE applying this Pull Request
Joomla as usual
Expected result AFTER applying this Pull Request
Joomla as usual, no difference is visible
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I will have to put these files into the list of files to keep in build/deleted_files.php so they won’t be putninto the List of files to be deleted on update. Putting it on my to do list for the case this PR will be merged, what I assume.
Thank you @richard67
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34962.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34962.
@wilsonge Do you really think we should keep the images on updates?
It means that we have to add all these files to the exclusion list here https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php#L155-L182 , because we already delete other images from the "/media/system/images" folder here https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L4860-L4873 .
If that would not be the case, we could just exclude the complete folder "/media/system/images" here: https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php#L63-L74 .
And maybe the latter is the better way, ignore the complete folder and its subfolder because they all contain only images which might be used somewhere else.
But then we should also remove these lines from script.php: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L4860-L4873 and https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L6142 .
Which way would you prefer?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-02 09:32:16 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Merging just so we don't have to care about potential deletions or not within the 4.x series
Both.
Both.
@wilsonge It seems you did not get which folder I mean. See my comment above again for details: #34962 (comment)
If that would not be the case, we could just exclude the complete folder "/media/system/images" here: https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php#L63-L74 .
And maybe the latter is the better way, ignore the complete folder and its subfolder because they all contain only images which might be used somewhere else.
But then we should also remove these lines from script.php: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L4860-L4873 and https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L6142 .
Which way would you prefer?
@wilsonge Or in other words: which of these 2 do you prefer?
-
4.0-dev...richard67:4.0-dev-deleted-files-update-files-to-keep-2021-08-02
-
4.0-dev...richard67:4.0-dev-deleted-files-update-files-to-keep-2021-08-02_variant-2
The first one results in only the files handled in this PR here being kept on update, while the second one results in all files in folder "/media/system/images" and its subfolders being kept.
4.0-dev...richard67:4.0-dev-deleted-files-update-files-to-keep-2021-08-02_variant-2 this one i think.
Done, see #35070 .
I have tested this item✅ successfully on 8648d1b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34962.