? ? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
28 Jul 2021

Pull Request for Issue #34643.

Summary of Changes

Fix override check as described in #34643 . Luckily, look like it is a small mistake (guess during the process converting SQL to prepared statement).

Testing Instructions

  1. Follow #34643 to understand the issue
  2. Download the Joomla update package from this PR. Modify code to the files which you created override before , then update Joomla and check the result. It should solve the issue.

Sorry if this is a wrong fix. Just a quick guess without fully understand how the system compare list of files to see the changes (first time looked at this feature and had to read code to understand how it works :D).

avatar joomdonation joomdonation - open - 28 Jul 2021
avatar joomdonation joomdonation - change - 28 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category Front End Plugins
avatar Kostelano Kostelano - test_item - 28 Jul 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 28 Jul 2021

I have tested this item successfully on 887aaf3

Thanks for the fix, everything works well now!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34960.

avatar jwaisner jwaisner - test_item - 28 Jul 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jul 2021

I have tested this item successfully on 887aaf3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34960.

avatar jwaisner jwaisner - change - 28 Jul 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 28 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34960.

avatar wilsonge wilsonge - change - 30 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-30 09:15:57
Closed_By wilsonge
Labels Added: ? ? ?
avatar wilsonge wilsonge - close - 30 Jul 2021
avatar wilsonge wilsonge - merge - 30 Jul 2021
avatar wilsonge
wilsonge - comment - 30 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment