NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
28 Jul 2021

Pull Request for Issue # .

Summary of Changes

  • The code had a monkey patch so that the last RC didn't had to be delayed. This PR removes the monkey patch

Testing Instructions

Apply the PR
Check that the Media Manager Editor is initializing all the plugins correctly
Check that the plugins still work as expected

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No, fixing my own ugly code

@wilsonge

avatar dgrammatiko dgrammatiko - open - 28 Jul 2021
avatar dgrammatiko dgrammatiko - change - 28 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category JavaScript Repository NPM Change
avatar RickR2H RickR2H - test_item - 28 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 28 Jul 2021

I have tested this item successfully on 28e889e

Applied patch and execute build tools. Rotate, scale, crop all work in the media manager.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34950.

avatar richard67 richard67 - test_item - 28 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 28 Jul 2021

I have tested this item successfully on 28e889e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34950.

avatar richard67 richard67 - change - 28 Jul 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 28 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34950.

avatar wilsonge wilsonge - change - 28 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-28 14:03:15
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Jul 2021
avatar wilsonge wilsonge - merge - 28 Jul 2021
avatar wilsonge
wilsonge - comment - 28 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment