? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
28 Jul 2021

Pull Request for Issue #34948.

Summary of Changes

Fix warning for HTMLHelper::_('calendar')

Testing Instructions

  1. See #34948 , confirm the issue
  2. Apply patch, confirm the issue fixed.
avatar joomdonation joomdonation - open - 28 Jul 2021
avatar joomdonation joomdonation - change - 28 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category Libraries
avatar Fedik
Fedik - comment - 28 Jul 2021

You was faster than me :)
Can you please add to the calendar layout extra check, if someoen use layout in own field:

'data-firstday'        => $firstday,
'data-weekend'         => implode(',', $weekend),

to

'data-firstday'        => empty($firstday) ? '' : $firstday,
'data-weekend'         => empty($weekend) ? '' : implode(',', $weekend),
avatar joomdonation
joomdonation - comment - 28 Jul 2021

@Fedik A small concern here. You removed the localesPath from layout data, so if someone overrides the joomla.form.field.calendar before, there would be warning. Not sure if that's something we have to care?

avatar Fedik
Fedik - comment - 28 Jul 2021

yeah, unfortunately they have to sync the override then,
because there no any localesPath anymore, and providing an empty string just hide a notice, however we can do that

avatar joomdonation joomdonation - change - 28 Jul 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category Libraries Layout Libraries
avatar joomdonation
joomdonation - comment - 28 Jul 2021

Ah, I see. It is because these js files were removed. OK, I committed the changes you requested. Should be fine now.

avatar Fedik Fedik - test_item - 28 Jul 2021 - Tested successfully
avatar Fedik
Fedik - comment - 28 Jul 2021

I have tested this item successfully on 52e1ac5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34949.

avatar RickR2H RickR2H - test_item - 28 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 28 Jul 2021

I have tested this item successfully on 52e1ac5

Error confirmed and patch works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34949.

avatar richard67 richard67 - change - 28 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34949.

avatar wilsonge wilsonge - change - 28 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-28 14:02:18
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Jul 2021
avatar wilsonge wilsonge - merge - 28 Jul 2021
avatar wilsonge
wilsonge - comment - 28 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment