[#34883] - [4.2] Fix code logic issues in Categories model
- Closed
- 29 Dec 2022
- Medium
- Build: 4.0-dev
- # 34883
- Diff
- joomdonation:categories_model_logic_fix
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In frontend Categories model of our components (com_content in this PR), there are few logic issues:
-
$paramsingetItemsmethod use params from the active menu item instead of calculated params stored in model states. With code like that, it will have wrong value for parameters set to Use Global in the menu item parameters (as it Use Global, it should get value from component Options but that's not working here because we are getting params directly from active menu item at the moment). -
The returned categories list does not depend on value of two model states
filter.accessandfilter.published. So if someone uses this model class and want to get list of unpublished categories (by settingfilter.publishedstate to 0, it won't work)
This PR fixes the two above logic issues in the code. If it is accepted, the similar changes should be done for other categories.
Testing Instructions
This is just code logic issues and does not have much effect how the system works, so there is not anything difference which testers can see. The only thing you can test is apply PR, create a menu item to link to List All Categories in an Article Category Tree and see that it is still working as expected.
I hope someone could review code, too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
@richard67 I don't think so. It is just code logic I found when I tried to find a solution for the issue #34866 .
| Labels |
Added:
?
|
||
I have tested this item
Hey, I have tested the changes and tried different settings.
I didn't notice anything else, except for the problem with sorting. #34866
It is still working as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34883.
@BertaOctech I just notice you have marked a test result, but not with the "Test this" button. It seems you have used "Alter test". Does that mean you have tested this pull request with success?
I have tested this item
@richard67
Hi,
Yes, you are right.
I did test the patch and I could not find anything wrong with it.
Cheers,
Berta
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34883.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34883.
| Labels |
Added:
?
?
?
Removed: ? |
||
| Title |
|
||||||
Quy
- | Labels |
Added:
?
Removed: ? |
||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Removed RTC as it is easy to do it in a BC way. When done we can add RTC again.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34883.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
Removed: ? ? ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-29 15:11:50 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Removed:
?
|
||
Are there any issues which are solved with this fix? If so, it would be good to find and close them.