? ? Pending

User tests: Successful: Unsuccessful:

avatar imanickam
imanickam
23 Jul 2021

Pull Request for Issue # .

It is not an issue; but, an improvement.

Summary of Changes

For example, if German is Switched as the back-end Administrator language, following message is displayed:
Die Administrationssprache wurde auf "German (Germany)" geändert.

With the change proposed, the following message would be displayed:
Die Administrationssprache wurde auf "Deutsch (Deutschland)" geändert.

When the message is displayed in the native language (e.g., German), it would be nice/better to show the language's Native Name/Title instead of the Name/Title in English.

Testing Instructions

  1. Log into Joomla! 4's back-end (site-url/administrator) with an account that has Super User privileges
  2. Install the German language by going to the screen "Extensions: Languages" (System => Install -> Languages)
  3. Go to the screen "Languages: Installed (Site)" (System => Manage -> Languages)
  4. Choose "Administrator" from the dropdown (that show the client) - The screen "Languages: Installed (Administrator)" would be shown and the list of languages installed that has Administrator pack would be shown
  5. Choose the language German and click on the button "Switch Language"

Now the German language would be the back-end administrator language. Also, a message confirming the language switch would be displayed as shown below in the German language.

Die Administrationssprache wurde auf "German (Germany)" geändert.

Notice that even though the message is in German, the language name shown is in English.

NOW, APPLY THE PATCH WITH THE CHANGE PROPOSED AND REPEAT THE TEST STEPS 1 TO 5 AS LISTED ABOVE.

After, German language is made as the back-end administrator language, following message would be displayed confirming the language switch.

Die Administrationssprache wurde auf "Deutsch (Deutschland)" geändert.

Notice the difference in the name of the language displayed between the messages before and after the change.

Actual result BEFORE applying this Pull Request

Notice that the message is in the native language (e.g, German) whereas the language name shown is in English.

Original_Language_Title_Shown

Expected result AFTER applying this Pull Request

Notice that the message is in the native language (e.g., German) and the language name shown is also in the native language (e.g., German).

Revised_Language_Native-Title_Shown

Documentation Changes Required

Probably Joomla! 4 documentation screenshot in case if the switching message is shown in the screenshot.

avatar imanickam imanickam - open - 23 Jul 2021
avatar imanickam imanickam - change - 23 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2021
Category Administration com_languages
avatar richard67
richard67 - comment - 24 Jul 2021

Can we be sure that all language packs provide the nativeName in their XML?

avatar Bakual
Bakual - comment - 24 Jul 2021

In J4, you can assume nativeName to be always present. In J3 there can be old packs which don't have it (it was added in a J3 release) but it's a required field since quite some time.
So if it's missing, it's a bug in the language pack.

avatar imanickam imanickam - change - 24 Jul 2021
Labels Added: ?
avatar richard67 richard67 - test_item - 24 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 24 Jul 2021

I have tested this item successfully on 800730d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34884.

avatar richard67
richard67 - comment - 24 Jul 2021

I've tested with all currently available J4 languages, which currently are:

2021-07-24_Language-switching_languages-available

It seems the Portuguese language pack uses wrong "QQ" in the language string for the message:

2021-07-24_Language-switching-errors_pt-PT

But it seems that's already fixed on Crowdin and so should be ok in future versions of that language pack.

avatar ceford ceford - test_item - 24 Jul 2021 - Tested successfully
avatar ceford
ceford - comment - 24 Jul 2021

I have tested this item successfully on 800730d

Works with German, French and Persion


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34884.

avatar richard67 richard67 - change - 24 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34884.

avatar brianteeman
brianteeman - comment - 24 Jul 2021

surely the native title for french is wrong and still in english

avatar brianteeman
brianteeman - comment - 24 Jul 2021

and welsh

avatar richard67
richard67 - comment - 24 Jul 2021

Yes ... they have to fix that in their translation packages.

avatar wilsonge wilsonge - close - 26 Jul 2021
avatar wilsonge wilsonge - merge - 26 Jul 2021
avatar wilsonge wilsonge - change - 26 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-26 19:34:11
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 26 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment