Feeling Lucky
?
?
[#34882] - [4.0] Transition Button - Replace hardcoded taskPrefix with option
- Fixed in Code Base
- 23 Jul 2021
- Medium
- Build: 4.0-dev
- # 34882
- Diff
- YatharthVyas:transition-btn-param
User tests: Successful: Unsuccessful:
Summary of Changes
In
transition-button layout, The onChange action is hard-coded to work for articles only because of articles.runTransition
This is a library layout and not a component-specific layout hence articles should not be hardcoded here and it should be taken as an option.
Testing Instructions
- Enable Workflows (Articles -> Options -> Integrations)
- Ensure that transitions work as intended after patch.
- Optionally, you can also check that the code of the transition field is same before and after patch:
Expected result AFTER applying this Pull Request
Transitions work as they did before
Documentation Changes Required
Not sure
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Layout |
| Labels |
Added:
?
|
||
richard67
- comment
- 23 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34882.
chmst
- comment
- 23 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34882.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 23 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34882.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-23 21:24:44 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 23 Jul 2021
Thanks!
YatharthVyas
- comment
- 24 Jul 2021
Thanks all!
Can we just inject the entire task rather than just the prefix please. It's going to be easier for other extensions who may not use core MVC