? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
23 Jul 2021

Summary of Changes

While translating, I noticed two undefined target="_new". In this PR, rel='noopener noreferrer' was also inserted directly.

Testing Instructions

The link will open in a new window/tab.

Actual result BEFORE applying this Pull Request

There is no keyword as _new in HTML5, and not in HTML4 (and consequently XHTML) either. That means, that there will be no consistent behavior whatsoever if you use this as a value for the target attribute.

Expected result AFTER applying this Pull Request

Browsing contexts can have a browsing context name. Unless stated otherwise, it is the empty string.

A valid browsing context name is any string with at least one character that does not start with a U+005F LOW LINE character. (Names starting with an underscore are reserved for special keywords.)

A valid browsing context name or keyword is any string that is either a valid browsing context name or that is an ASCII case-insensitive match for one of: _blank, _self, _parent, or _top.

Source: https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-names

Documentation Changes Required

.

c0d99b7 23 Jul 2021 avatar tecpromotion fix
avatar tecpromotion tecpromotion - open - 23 Jul 2021
avatar tecpromotion tecpromotion - change - 23 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2021
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 23 Jul 2021

Looks good. Does it also have to be done in J3 ?

avatar tecpromotion
tecpromotion - comment - 23 Jul 2021

Looks good. Does it also have to be done in J3 ?

yes. new pr for 3 or merge in staging/3.10-dev?

avatar ceford
ceford - comment - 24 Jul 2021

I can't find the string keys anywhere in the Joomla 4 code!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34881.

avatar brianteeman
brianteeman - comment - 24 Jul 2021

Look again

avatar brianteeman
brianteeman - comment - 24 Jul 2021

seriously though. iirc they are needed for upgrades

avatar ceford
ceford - comment - 24 Jul 2021

Look again

I looked again. The string keys occur in ini files but I do not see them anywhere in the code. If I have somehow missed them could you explain where? Or if not in the code exactly how they get used.

avatar brianteeman
brianteeman - comment - 24 Jul 2021

seriously though. iirc they are needed for upgrades

#31838

avatar RickR2H RickR2H - test_item - 28 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 28 Jul 2021

I have tested this item successfully on c0d99b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34881.

avatar richard67
richard67 - comment - 30 Jul 2021

seriously though. iirc they are needed for upgrades

#31838

Correct. So for testing it needs to update a 3.10 to 4 and then check the postinstall messages without and with this PR applied.

avatar richard67 richard67 - test_item - 30 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 30 Jul 2021

I have tested this item successfully on c0d99b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34881.

avatar richard67 richard67 - change - 30 Jul 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 30 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34881.

avatar richard67
richard67 - comment - 30 Jul 2021

Setting RTC because 2 good tests ... maintainers will respect the milestone "4.0.1" due to the language freeze.

avatar bembelimen bembelimen - change - 23 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-23 01:13:12
Closed_By bembelimen
Labels Added: ? Language Change ?
Removed: ? ?
avatar bembelimen bembelimen - close - 23 Aug 2021
avatar bembelimen bembelimen - merge - 23 Aug 2021
avatar bembelimen
bembelimen - comment - 23 Aug 2021

Thx

Add a Comment

Login with GitHub to post a comment