User tests: Successful: Unsuccessful:
While translating, I noticed two undefined target="_new". In this PR, rel='noopener noreferrer' was also inserted directly.
The link will open in a new window/tab.
There is no keyword as _new in HTML5, and not in HTML4 (and consequently XHTML) either. That means, that there will be no consistent behavior whatsoever if you use this as a value for the target attribute.
Browsing contexts can have a browsing context name. Unless stated otherwise, it is the empty string.
A valid browsing context name is any string with at least one character that does not start with a U+005F LOW LINE character. (Names starting with an underscore are reserved for special keywords.)
A valid browsing context name or keyword is any string that is either a valid browsing context name or that is an ASCII case-insensitive match for one of: _blank, _self, _parent, or _top.
Source: https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-names
.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
Looks good. Does it also have to be done in J3 ?
yes. new pr for 3 or merge in staging/3.10-dev?
I can't find the string keys anywhere in the Joomla 4 code!
Look again
seriously though. iirc they are needed for upgrades
Look again
I looked again. The string keys occur in ini files but I do not see them anywhere in the code. If I have somehow missed them could you explain where? Or if not in the code exactly how they get used.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
?
|
RTC
Setting RTC because 2 good tests ... maintainers will respect the milestone "4.0.1" due to the language freeze.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 01:13:12 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
Language Change
?
Removed: ? ? |
Thx
Looks good. Does it also have to be done in J3 ?