?
avatar chmst
chmst
22 Jul 2021

Steps to reproduce the issue

Install at least two languages, but don't make the site multilingual.

Go to Artilces overview.
The language column is not shown.
Activate one or more items and call the action "Batch".

Expected result

On the batch modal, language change is not enabled

Actual result

language change is enabled

grafik

This is a bit confusing, because you don't know which language now is set for the articles.

How to resolve this? Change the language select field or check every batch modal?

avatar chmst chmst - open - 22 Jul 2021
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Jul 2021
avatar brianteeman
brianteeman - comment - 22 Jul 2021

How to resolve this? Change the language select field or check every batch modal?

I would say that the preferred option is to add the if (Multilanguage::isEnabled()) check to every batch modal but an alternative would be to do that once in the layout but this might result in invalid html

avatar chmst
chmst - comment - 22 Jul 2021

Agree, simple but no risk. I will do it right now for weblinks where I am working at the moment.

avatar brianteeman
brianteeman - comment - 23 Jul 2021

should I do it here ?

avatar chmst
chmst - comment - 24 Jul 2021

If you have the time, yes, please!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34874.

avatar brianteeman
brianteeman - comment - 24 Jul 2021

Filming this morning. Will do it tonight

On Sat, 24 Jul 2021, 08:21 Christiane Maier-Stadtherr, <
@.***> wrote:

If you have the time, yes, please!

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/tracker/joomla-cms/34874.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34874 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4MFZWRLIL24Q4IKOGDTZJSWNANCNFSM5A2XJIFA
.

avatar richard67 richard67 - change - 24 Jul 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-07-24 13:06:01
Closed_By richard67
avatar richard67 richard67 - close - 24 Jul 2021
avatar richard67
richard67 - comment - 24 Jul 2021

Closing as having a pull request. Please test #34887 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment