NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
22 Jul 2021

Pull Request for Comment mentioned on PR #34869 (comment) .

Summary of Changes

Fixes icons for the sidebar in com_config

Testing Instructions

Look at the actions sidebar in com_config. Before patch it's as the screenshot shows in the comment in the above PR. After patching it's "correct" (see below)

Screenshot 2021-07-22 at 23 46 40

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 22 Jul 2021
avatar wilsonge wilsonge - change - 22 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2021
Category Administration Templates (admin) NPM Change
avatar wilsonge wilsonge - change - 22 Jul 2021
The description was changed
avatar wilsonge wilsonge - edited - 22 Jul 2021
avatar wilsonge wilsonge - change - 22 Jul 2021
Title
Fix com_config sidebar in RTL
[4.0] Fix com_config sidebar in RTL
avatar wilsonge wilsonge - edited - 22 Jul 2021
avatar richard67 richard67 - test_item - 23 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 23 Jul 2021

I have tested this item successfully on 094beba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34875.

8a85cb2 23 Jul 2021 avatar richard67 CS
avatar richard67 richard67 - change - 23 Jul 2021
Labels Added: NPM Resource Changed ?
avatar richard67 richard67 - alter_testresult - 23 Jul 2021 - richard67: Tested successfully
avatar richard67
richard67 - comment - 23 Jul 2021

@wilsonge I've allowed myself to fix the code style issue.

avatar ChristineWk ChristineWk - test_item - 23 Jul 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 23 Jul 2021

I have tested this item successfully on 094beba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34875.

avatar richard67 richard67 - alter_testresult - 23 Jul 2021 - ChristineWk: Tested successfully
avatar richard67
richard67 - comment - 23 Jul 2021

I've restored the test results in the tracker because the commit after the tests was just a code style change.

avatar richard67 richard67 - change - 23 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34875.

avatar wilsonge wilsonge - change - 23 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-23 11:35:56
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jul 2021
avatar wilsonge wilsonge - merge - 23 Jul 2021
avatar wilsonge
wilsonge - comment - 23 Jul 2021

Thanks!

Add a Comment

Login with GitHub to post a comment