Feeling Lucky
?
NPM Resource Changed
?
[#34655] - [4.0] Media Field changes
- Closed
- 30 Jun 2021
- Medium
- Build: 4.0-dev
- Draft PR
- # 34655
- Diff
- dgrammatiko:—media-field-more-4.0-dev
User tests: Successful: Unsuccessful:
Pull Request is a follow up for #34634 .
Summary of Changes
- Expose the types attribute for the media fields
- Adjusts the preview
Testing Instructions
Will post them once the other PR is merged.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_media JavaScript NPM Change Language & Strings Repository SQL Installation Postgresql Layout Libraries |
dgrammatiko
- comment
- 30 Jun 2021
@brianteeman my intention is not to change existing image fields to support more media types. The change in the article form is an artifact as I was working/testing this
brianteeman
- comment
- 30 Jun 2021
sorry I dont understand
dgrammatiko
- comment
- 30 Jun 2021
sorry I dont understand
So, this PR introduces a new attribute for the Media Field (xml types="images,audios,videos,documents").
- Without setting this field the media field is totally compatible (eg only images)
- Setting the value in a field's xml a dev can control what types of media the field could handle
The change in the article.xml file is purely for testing/valiation purposes, won't be part of the PR
| Labels |
Added:
?
NPM Resource Changed
?
|
||
dgrammatiko
- comment
- 30 Jun 2021
Closing this as I merged the changes to the other PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-30 13:42:37 |
| Closed_By | ⇒ | dgrammatiko |
I dont see the need for this PR. Those are image fields. Or am I missing something?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34655.