NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
29 Jun 2021

Pull Request for Issue #34649 .

Summary of Changes

  • Remove the sanitizer, the buttons are embeded in the js so they are safe
  • Clean up the file
  • Load the script as a type=module

Testing Instructions

Test that the toolbar icons are displaying correctly and the drag and drop functionality still intact

Actual result BEFORE applying this Pull Request

Broken

Expected result AFTER applying this Pull Request

Working

Documentation Changes Required

No bug fix

avatar dgrammatiko dgrammatiko - open - 29 Jun 2021
avatar dgrammatiko dgrammatiko - change - 29 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2021
Category JavaScript Repository NPM Change Layout
6fd769e 29 Jun 2021 avatar dgrammatiko meh
avatar dgrammatiko dgrammatiko - change - 29 Jun 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - test_item - 30 Jun 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Jun 2021

I have tested this item successfully on 6fd769e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34654.

avatar RickR2H RickR2H - test_item - 30 Jun 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 30 Jun 2021

I have tested this item successfully on 6fd769e

Icons work! Thanks Dimitris for the quick response!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34654.

avatar wilsonge wilsonge - change - 30 Jun 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-30 07:42:28
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Jun 2021
avatar wilsonge wilsonge - merge - 30 Jun 2021
avatar wilsonge
wilsonge - comment - 30 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment