Feeling Lucky
NPM Resource Changed
?
?
[#34513] - [4.0] Fix form validation error
- Fixed in Code Base
- 14 Jun 2021
- Medium
- Build: 4.0-dev
- # 34513
- Diff
- joomdonation:fix_validate_error
User tests: Successful: Unsuccessful:
Pull Request for Issue #34511.
Summary of Changes
Added code to check and make sure message is not null before calling Joomla.sanitizeHtml to avoid javascript error. See the original issue for more details.
Testing Instructions
- See #34511 to understand the issue.
- Download update package for this PR at https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34513/downloads/45176/Joomla_4.0.0-rc2-dev+pr.34513-Development-Update_Package.zip
, go to System -> Update -> Joomla, upload this package and run the update. - Check it again, confirm the original issue fixed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
joomdonation
- comment
- 14 Jun 2021
@dgrammatiko That's why we need to use IDE to code. Fixed :).
joomdonation
- comment
- 14 Jun 2021
Could someone please test this simple PR? It would be nice to have it tested and included in next RC release to avoid issues being reported when people update to RC2. Thanks !
dgrammatiko
- comment
- 14 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34513.
alikon
- comment
- 14 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34513.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 14 Jun 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34513.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-14 20:12:16 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 14 Jun 2021
Thanks!
@joomdonation oops I removed one extra?♂️
)at the end of each line