?
avatar RickR2H
RickR2H
14 Jun 2021

Steps to reproduce the issue

  1. Go to System -> Mail Templates -> open the "Global Configuration: Test Mail" mail template.
  2. Try to add an attachment by clicking the "Plus button".
  3. There should be a field to upload and add the attachment, but only a blank space is added.

screen shot 2021-06-14 at 10 12 24

avatar RickR2H RickR2H - open - 14 Jun 2021
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Jun 2021
avatar richard67
richard67 - comment - 14 Jun 2021

@RickR2H I can't reproduce this on a clean, new installation of current 4.0-dev. In this case, the "Attachments Folder" option in the Media Manager component's options is empty, so there is no "+" button shown in any of the mail templates to add an attachment.

So my questions are:

  1. Have you used a new installation of current 4.0-dev or latest nightly? Or have you used an installation which was updated in past? If so, please let us know the update history.
  2. What is the value of the "Attachments Folder" option in the Media Manager component's options of your installation?
avatar joomdonation
joomdonation - comment - 14 Jun 2021

@richard67 I can confirm the issue. Currently, look like subform is not working at all. For example, we can add a new custom field checkbox and could not add options for the custom field anymore

avatar sandramay0905
sandramay0905 - comment - 14 Jun 2021

I got the issue reported by @RickR2H if i set in options of mail templates the Attachment Folder to images.

avatar richard67
richard67 - comment - 14 Jun 2021

I got the issue reported by @RickR2H if i set in options of mail templates the Attachment Folder to images.

Confirmed.

avatar richard67
richard67 - comment - 14 Jun 2021

@richard67 I can confirm the issue. Currently, look like subform is not working at all. For example, we can add a new custom field checkbox and could not add options for the custom field anymore

@joomdonation Last change for subforms in J4 was #31567 . Could it be related to that PR? Or has the upmerge from 3.10-dev broken something from that PR?

avatar richard67
richard67 - comment - 14 Jun 2021

@joomdonation Could you open an issue for the general subforms issue and we make it a release blocker? Or should we use this issue here to continue and make it a release blocker?

avatar joomdonation
joomdonation - comment - 14 Jun 2021

@richard67 We could use this issue here to continue. I don't know subform code enough to confirm where this issue comes from. Maybe @Fedik could help ?

avatar Fedik
Fedik - comment - 14 Jun 2021

I will try to look what's going on

avatar joomdonation
joomdonation - comment - 14 Jun 2021

Sorry @dgrammatiko . Look like it causes by Joomla.sanitizeHtml too. If we change this line of code to https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/js/fields/joomla-field-subform.w-c.es6.js#L186 to :

tmpEl.innerHTML = this.template;

The issue is gone. Could you please look at this?

avatar joomdonation
joomdonation - comment - 14 Jun 2021

Ah, we added comment at the same time :).

avatar dgrammatiko
dgrammatiko - comment - 14 Jun 2021

@joomdonation here's a PR: #34514

avatar joomdonation joomdonation - close - 15 Jun 2021
avatar joomdonation
joomdonation - comment - 15 Jun 2021

Fixed on PR #34514 , so closing this issue.

avatar joomdonation joomdonation - change - 15 Jun 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-06-15 02:10:04
Closed_By joomdonation

Add a Comment

Login with GitHub to post a comment