? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
9 Jun 2021

Pull Request for Issue # .

Summary of Changes

Changed the order of the fields in content global config to match the order of the fields in menu. Added description for article class field.

Testing Instructions

Go to Content > Options > Blog/Featured Layouts
(compare with the layout of a menu of type Category Blog)

Actual result BEFORE applying this Pull Request

The field Article Class is after the columns fields, no description

Screenshot 2021-06-09 at 08-38-27 Articles Options - Joomla 4 RC - Administration

Expected result AFTER applying this Pull Request

The field Article Class is directly after # Articles and has a description

Screenshot 2021-06-09 at 08-39-09 Articles Options - Joomla 4 RC - Administration

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 9 Jun 2021
avatar drmenzelit drmenzelit - change - 9 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2021
Category Administration com_content
avatar drmenzelit drmenzelit - change - 9 Jun 2021
Title
[4.0] Change order of fields and add description
[4.0] Change order of fields and add description in content global options
avatar drmenzelit drmenzelit - edited - 9 Jun 2021
avatar sandramay0905 sandramay0905 - test_item - 9 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 9 Jun 2021

I have tested this item successfully on c9bae62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34469.

avatar sandramay0905
sandramay0905 - comment - 9 Jun 2021

Can this description be on help screen? User who need this help may not know what "CSS" is, other don't need this help.

avatar RickR2H
RickR2H - comment - 9 Jun 2021

Why not change the field to a combo field? That way you can add default values to the dropdown and als add your own classes in necessary.
https://docs.joomla.org/Combo_form_field_type


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34469.

avatar drmenzelit
drmenzelit - comment - 9 Jun 2021

@RickR2H I like the idea, but I will make a separate PR for that

avatar RickR2H
RickR2H - comment - 9 Jun 2021

@drmenzelit Then we will have best of both worlds! DM me to test when you are ready!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34469.

avatar drmenzelit
drmenzelit - comment - 9 Jun 2021

@RickR2H the problem with combo is that you can't enter more than one class... we need something like the tags fields...

avatar RickR2H
RickR2H - comment - 9 Jun 2021

@drmenzelit i did some testing and in J3 you can select one option and then add other classes by hand. J4 combo has no dropdown so also no indication that there are default values. A tag field like option would we the best I guess.
J3
j3-combo
J4
j4-combo

avatar chmst chmst - test_item - 12 Jun 2021 - Tested successfully
avatar chmst
chmst - comment - 12 Jun 2021

I have tested this item successfully on c9bae62

This PR does what it says. Further improvment in an extra pr.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34469.

avatar richard67 richard67 - change - 12 Jun 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 12 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34469.

avatar Quy Quy - change - 12 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-12 14:48:54
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 12 Jun 2021
avatar Quy Quy - merge - 12 Jun 2021
avatar Quy
Quy - comment - 12 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment