[#34470] - Fix W3C Warning for breadcrumbs: role="navigation" is unnecessary for element nav
- Closed
- 10 Jun 2021
- Medium
- Build: 4.0-dev
- # 34470
- Diff
- RickR2H:breadcrumbs-aria
User tests: Successful: Unsuccessful:
Summary of Changes
The breadcrumbs have the ARIA role="navigation", but this is unnecessary for nav elements. Also added a class to the breadcrumbs nav element for easy styling.
Testing Instructions
Look at the code of the breadcrumbs and see if the the role element is there. Apply the patch and check if the role element is gone and the class added.
Actual result BEFORE applying this Pull Request
breadcrumbs nav has role="navigation"
Expected result AFTER applying this Pull Request
breadcrumbs nav has no role="navigation" and has class="breadcrumbs-container"
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Looks fine.
Other places concerned, first one concerns media breadcrumbs
joomla40/administrator/components/com_media/resources/scripts/components/breadcrumb/breadcrumb.vue:4: role="navigation"
joomla40/layouts/joomla/pagination/links.php:56: <nav role="navigation" aria-label="<?php echo Text::_('JLIB_HTML_PAGINATION'); ?>">
joomla40/layouts/joomla/pagination/list.php:17: <nav role="navigation" aria-label="<?php echo Text::_('JLIB_HTML_PAGINATION'); ?>">
joomla40/libraries/vendor/codeception/codeception/ext/Recorder.php:139: <nav class="navbar navbar-expand-lg navbar-light bg-light" role="navigation">
joomla40/libraries/vendor/codeception/codeception/ext/Recorder.php:219: <nav class="navbar navbar-expand-lg navbar-light bg-light" role="navigation">
@infograf768 Thanks for the search! Made some changes to the mentioned files. The only problem is that joomla40/libraries/vendor/codeception/codeception/ext/Recorder.php is excluded from the repo. I don't know how to add this to the code. Can you help?
| Labels |
Added:
?
|
||
| Category | Modules Front End | ⇒ | Administration com_media NPM Change Layout Modules Front End |
codeception is third party. I guess the only way would be to propose a patch https://github.com/codeception/codeception/issues. The rest is fine.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34470.
@infograf768 I also added a PR to codeception.
for future reference creating a nav with a role=navigation used to be needed for browsers that did not support html5
For new specific classes it would be best if you adopted BEM naming convention. There is a good explanation here #32267
@brianteeman I agree! But the child element of nav has already the Block Element Class. If the previous implementation was done right, the nav should have the Block Element Class. Not the first child. Me not trying to mess up the styling of the template, I implemented a container class.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34470.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34470.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Modules Front End Administration com_media NPM Change Layout | ⇒ | Repository Administration com_media NPM Change Layout Modules Front End |
| Category | Modules Front End Administration com_media NPM Change Layout Repository | ⇒ | Repository Administration com_admin SQL Postgresql MS SQL com_banners com_config com_finder com_languages com_media NPM Change com_search Language & Strings Front End External Library Composer Change |
@richard67 Sorry my mistake! Was working in the wrong branch.
| Labels |
Added:
?
?
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as the branch of this PR has received new, wrong commits.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34470.
@richard67 I'll create a new PR. That's quicker
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-10 07:52:19 |
| Closed_By | ⇒ | RickR2H | |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 3ef4a33
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34470.