Feeling Lucky
?
?
?
[#34466] - ARIA IDs are not unique when there are multiple menu's active
- Fixed in Code Base
- 9 Jun 2021
- Medium
- Build: 4.0-dev
- # 34466
- Diff
- RickR2H:unique-navbar-id
User tests: Successful: Unsuccessful:
Summary of Changes
When there are mut
The mod_menu layout collapse-default.php and the mod_menu collapse-metismenu.php layout override in the Cassiopeia all share the same ID (#navbar). When there are multiple menu's with these layouts, then this will result in accessibility problems because every menu must have an unique ID. Also for lot of other reasons it's not advisable to have multiple elements with the same ID in a website.
Testing Instructions
- Go to the modules and copy the Main Menu Module two times. Put one of them in the position "menu" and leave the other in the position "sidebar-right".
- The two modules in the position "sidebar-right" must have the Layout set to: Collapsible Default Menu
- The module in position "menu" must have the Layout set to: Collapsible Dropdown
- Activate the menu modules.
- Look at the code to verify that the modules with there layouts, all have the same ID.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End Templates (site) |
ricardo1709
- comment
- 9 Jun 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34466.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 9 Jun 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34466.
RickR2H
- comment
- 9 Jun 2021
Thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-09 10:14:03 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
chmst
- comment
- 9 Jun 2021
Thanks!
I have tested this item✅ successfully on b21830d
All
id="navbar"changed using pull request toid=navbar[unique-number].This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34466.