NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Jun 2021

PR for #33590
This does not fix all the issues but it fixes the majority

For an analysis of why the sidebar is not always open and the active item not selected see #34067

To test
First make sure that you can replicate the problem by replicating the first few issues reported at #33590

Now apply the pr and rebuild the js
Now try to replicate the issues reported at #33590

This PR does NOT fix the links from a category which is a different issue
(I know what is needed to fix it I just dont know how to get the $default_view for a component when I am in com_categories)

This PR does NOT fix the context links for com_fields which is a different issue
( look at the url when you change the dropdown)

avatar brianteeman brianteeman - open - 8 Jun 2021
avatar brianteeman brianteeman - change - 8 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2021
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - change - 8 Jun 2021
The description was changed
avatar brianteeman brianteeman - edited - 8 Jun 2021
avatar brianteeman
brianteeman - comment - 9 Jun 2021

The active attribute is added to a menu link when the current url matches the link.

The problem with the links from com_categories is that they do not include the view and so never match with a link in the menu. The links from com_categories only work because they rely on the default view of the component

A php solution to this would be add the default view to the link in com_categories.

avatar drmenzelit
drmenzelit - comment - 9 Jun 2021

I tested with
Joomla Admin -> Content -> Media = PR works
Components -> Smart Search -> Content Maps -> Click the number of published indexed content = PR works
Content -> Fields -> Select category in the drop down -> Select articles in the dropdown = PR doesn't work, menu collapses (I don't know if it is related with the category problem)

avatar brianteeman
brianteeman - comment - 9 Jun 2021

Content -> Fields -> Select category in the drop down -> Select articles in the dropdown = PR doesn't work, menu collapses

That's a different issue - look at the url when you change the dropdown

avatar drmenzelit drmenzelit - test_item - 9 Jun 2021 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 9 Jun 2021

I have tested this item successfully on 4df1cd6

Joomla Admin -> Content -> Media = PR works
Components -> Smart Search -> Content Maps -> Click the number of published indexed content = PR works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34465.

avatar brianteeman brianteeman - change - 9 Jun 2021
The description was changed
avatar brianteeman brianteeman - edited - 9 Jun 2021
avatar sandramay0905 sandramay0905 - test_item - 9 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 9 Jun 2021

I have tested this item successfully on 4df1cd6

Test successfully both components like @drmenzelit.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34465.

avatar richard67 richard67 - change - 9 Jun 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 9 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34465.

avatar PhilETaylor
PhilETaylor - comment - 9 Jun 2021

Ive tested this today, its not perfect but is a million times better. I'll close the #33590 and document any left over issues overtime

avatar brianteeman
brianteeman - comment - 9 Jun 2021

@PhilETaylor if you have the time to help with the php to get the value of the default view from a component then I can update it with the fix for com_categories.

avatar chmst chmst - close - 9 Jun 2021
avatar chmst chmst - merge - 9 Jun 2021
avatar chmst chmst - change - 9 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-09 10:13:14
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 9 Jun 2021

Thanks!

avatar brianteeman
brianteeman - comment - 9 Jun 2021

thanks all

avatar Quy
Quy - comment - 9 Jun 2021

Home Dashboard is always active.

34465

Add a Comment

Login with GitHub to post a comment