User tests: Successful: Unsuccessful:
PR for #33590
This does not fix all the issues but it fixes the majority
For an analysis of why the sidebar is not always open and the active item not selected see #34067
To test
First make sure that you can replicate the problem by replicating the first few issues reported at #33590
Now apply the pr and rebuild the js
Now try to replicate the issues reported at #33590
This PR does NOT fix the links from a category which is a different issue
(I know what is needed to fix it I just dont know how to get the $default_view for a component when I am in com_categories)
This PR does NOT fix the context links for com_fields which is a different issue
( look at the url when you change the dropdown)
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
I tested with
Joomla Admin -> Content -> Media = PR works
Components -> Smart Search -> Content Maps -> Click the number of published indexed content = PR works
Content -> Fields -> Select category in the drop down -> Select articles in the dropdown = PR doesn't work, menu collapses (I don't know if it is related with the category problem)
Content -> Fields -> Select category in the drop down -> Select articles in the dropdown = PR doesn't work, menu collapses
That's a different issue - look at the url when you change the dropdown
I have tested this item
Joomla Admin -> Content -> Media = PR works
Components -> Smart Search -> Content Maps -> Click the number of published indexed content = PR works
I have tested this item
Test successfully both components like @drmenzelit.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
NPM Resource Changed
|
RTC
@PhilETaylor if you have the time to help with the php to get the value of the default view from a component then I can update it with the fix for com_categories.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-09 10:13:14 |
Closed_By | ⇒ | chmst | |
Labels |
Added:
?
|
Thanks!
thanks all
The active attribute is added to a menu link when the current url matches the link.
The problem with the links from com_categories is that they do not include the view and so never match with a link in the menu. The links from com_categories only work because they rely on the default view of the component
A php solution to this would be add the default view to the link in com_categories.