NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Jun 2021

bumps codemirror version to 5.61.1

avatar brianteeman brianteeman - open - 5 Jun 2021
avatar brianteeman brianteeman - change - 5 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jun 2021
Category NPM Change Front End Plugins
avatar richard67 richard67 - test_item - 6 Jun 2021 - Tested successfully
avatar richard67
richard67 - comment - 6 Jun 2021

I have tested this item successfully on 14dcf2d

I've run npm update codemirror on a clean current 4.0-dev branch. The changes in package-lock.json after that are the same as made with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34423.

avatar brianteeman
brianteeman - comment - 6 Jun 2021

did you also check the version number in the xml?

avatar richard67
richard67 - comment - 6 Jun 2021

did you also check the version number in the xml?

@brianteeman Sure, but that's just a normal code change and not a result of npm so I thought it's not worth to be mentioned.

avatar brianteeman
brianteeman - comment - 6 Jun 2021

it is not a manual code change. it is created by the build.js scripts when npm installs a new version of codemirror,tinymce (and others)

avatar richard67
richard67 - comment - 6 Jun 2021

@brianteeman I see. Well, that works, too. I've just tested.

avatar jwaisner jwaisner - test_item - 6 Jun 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Jun 2021

I have tested this item successfully on 14dcf2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34423.

avatar jwaisner jwaisner - change - 6 Jun 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 6 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34423.

avatar wilsonge wilsonge - close - 6 Jun 2021
avatar wilsonge wilsonge - merge - 6 Jun 2021
avatar wilsonge wilsonge - change - 6 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-06 18:08:48
Closed_By wilsonge
Labels Added: NPM Resource Changed ? ?
avatar wilsonge
wilsonge - comment - 6 Jun 2021

Thanks!

avatar brianteeman
brianteeman - comment - 6 Jun 2021

thx

Add a Comment

Login with GitHub to post a comment