[#34422] - [4.0] Fix query after prepared statements
- Fixed in Code Base
- 6 Jun 2021
- Medium
- Build: 4.0-dev
- # 34422
- Diff
- chmst:mod-tags-poular-query-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #34417.
Summary of Changes
Fix binding in sql statement when ordering with title.
Thank you for help, @joomdonation and @richard67
Testing Instructions
See issue #34417.
Make a module tags-popular and select ordering "title"
Actual result BEFORE applying this Pull Request
Error
Expected result AFTER applying this Pull Request
Correct output of tags ordered by title
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
@chmst Looking more at DatabaseQuery class, I found a better solution and made PR chmst#12 to your branch. Could you please review, test and if it works good, merge it please.
The current code require us to rebind value for each parameters in the right order (depend on the position it is called in the query), so it is not good and flexible enough (don't know how to explain more clear, happy to discuss directly on Glip if needed)
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. One more test needed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
@joomdonation It's not sufficient just to remove the RTC label here on GitHub because the issue tracker still has status "Ready to Commit" and so will add it back with the next change to the issue, e.g. if someone tests again. For removing RTC you have to change the status in the issue tracker back to pending with some comment at the bottom, same way as when setting RTC.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-06 13:22:56 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
I have tested this item✅ successfully on 7abb490
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34422.