Information Required NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar ThisIsFaar
ThisIsFaar
6 Jun 2021

(Updated Pull Request of #34387)

Pull Request for Issue #32820 .

Summary of Changes
Views overflow fixed, now any number of columns can be added without worsening UI.

Before Fix
Before

After Fix
After

avatar ThisIsFaar ThisIsFaar - open - 6 Jun 2021
avatar ThisIsFaar ThisIsFaar - change - 6 Jun 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2021
Category Administration Templates (admin) NPM Change
avatar ThisIsFaar ThisIsFaar - change - 6 Jun 2021
Labels Added: NPM Resource Changed ?
avatar ThisIsFaar
ThisIsFaar - comment - 6 Jun 2021

image

Source https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar

compatibility issues for ::-webkit-scrollbar found in firefox, internet explorer.

image

So for firefox, IE:-

image

Mozilla Testing

mozilla firefox

avatar sandramay0905 sandramay0905 - test_item - 8 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 8 Jun 2021

I have tested this item successfully on 9d3a5a0

Test views of

  • articles,
  • categories,
  • featured articles,
  • fields
  • modules
  • banners + categories + clients
  • contacts + categories + fields
  • feeds + categories
  • smart search + index + content maps
  • tags
  • users + fields
  • templates

System:

avatar Fedik
Fedik - comment - 14 Jun 2021

The fix looks a bit strange, why do you hide scrollbars?

avatar ThisIsFaar
ThisIsFaar - comment - 18 Jun 2021

The fix looks a bit strange, why do you hide scrollbars?

because I was told to hide, check out some last comments of the conversation from the issue #34387

avatar Fedik
Fedik - comment - 18 Jun 2021

okay, and do you see why did you got scrollbars that you have to hide?

please looks there https://developer.mozilla.org/en-US/docs/Web/CSS/overflow

avatar Fedik
Fedik - comment - 18 Jun 2021

Remove scrollbar-width stuff and .container-main::-webkit-scrollbar.
And use overflow:auto; instead of scroll.

avatar ThisIsFaar ThisIsFaar - change - 18 Jun 2021
Labels Added: Information Required
avatar ThisIsFaar
ThisIsFaar - comment - 18 Jun 2021

hello @Fedik, overflow auto-added. please test and verify

avatar Fedik Fedik - test_item - 21 Jun 2021 - Tested successfully
avatar Fedik
Fedik - comment - 21 Jun 2021

I have tested this item successfully on 5b7ccc6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34426.

avatar Quy Quy - test_item - 1 Jul 2021 - Tested successfully
avatar Quy
Quy - comment - 1 Jul 2021

I have tested this item successfully on 5b7ccc6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34426.

avatar Quy Quy - change - 1 Jul 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34426.

avatar bembelimen bembelimen - change - 2 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-02 07:51:18
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 2 Jul 2021
avatar bembelimen bembelimen - merge - 2 Jul 2021
avatar bembelimen
bembelimen - comment - 2 Jul 2021

Thank you!

avatar Quy
Quy - comment - 16 Jul 2021

See #34793 for regression.

Add a Comment

Login with GitHub to post a comment