LMAO And this is why my first PR was right... but you opposed it. to the point I changed it.

Where? There is nothing in that link remotely related

Where? There is nothing in that link remotely related

Im sorry you feel that way... but once again you are wrong.

if you had not opposed it the text would have remained

"You do not have any popular articles yet"
"You do not have any recent articles yet" 

The "Empty State" of these modules is not "There are no articles, you have not ever created any"... That is the empty state of the component...

These modules are not aware of the FULL table of content, they are only aware if there is something to show or not... its not a real "empty state" like the "empty state" is defined for the extensions, it more a "text string when there is no items to show"... and therefore the original language like those below is "more correct" and that is what #33472 proposed.

"You do not have any popular articles yet"
"You do not have any recent articles yet"

And the two articles strings are NOT trying to say that there are no articles in the database, they are trying to say that the purpose of the module is a empty state, and as the data for these modules is about Popular and Recently added articles, the language has to reflect that underlying dataset - there are no popular articles and there are no recent articles.

And that was the whole purpose originally of the textSuffix

'textSuffix' => '_RECENT',

'textSuffix' => '_POPULAR',

Which again, you just removed earlier today /facepalm

Sorry but the text of the string is nothing to do with the issue. An article can be popular and still be archived. An article can be recently created and still be archived.

An article can be popular and still be archived. An article can be recently created and still be archived.

Yes, but Even before empty state, these modules have NEVER shown archived items...

Even before empty state, these modules would have shown nothing...

To test. Change the state of all articles to archived and check these two modules. They are displaying "No Articles have been created yet." which is not correct

So what exactly is your EXPECTED behaviour?

Maybe

"You do not have any non-archived popular articles yet"
"You do not have any non-archived recent articles yet" 

Maybe a good chance to think about a take-back of these strange emptystate codes from at least modules; with additional DB queries and JLayouts for nothing than a message.

with additional DB queries

Empty State for modules DOESN'T run any additional DB Queries at all.

Empty State for Extensions ONLY runs a single additional DB query when NO ITEMS are about to be shown.

On a normal site, with data in the db, Empty State Design DOESN'T have any overhead whatsoever ever.

Until @brianteeman answers the question, "what exactly is your EXPECTED behaviour" there is nothing that can be achieved on this issue.