[#34380] - [4.0] Composer update joomla/utilities
- Fixed in Code Base
- 5 Jun 2021
- Medium
- Build: 4.0-dev
- # 34380
- Diff
- richard67:4.0-dev-composer-update-joomla-utilities
User tests: Successful: Unsuccessful:
Pull Request for Issue #34365 .
Summary of Changes
Update composer dependency "joomla/utilities" to latest version "2.0.0-beta2" which contains the fix for issue 34365 .
Testing Instructions
Code review.
Or apply the patch to a clean, current 4.0-dev branch where "composer install" and "npm ci" have been run before, and then run "composer install" again.
Result: "joomla/utilities" is updated from "2.0.0-beta" to "2.0.0-beta2". Nothing else is updated, added or removed by composer.
Actual result BEFORE applying this Pull Request
Version "2.0.0-beta" of the composer dependency "joomla/utilities" is used.
Expected result AFTER applying this Pull Request
Version "2.0.0-beta2" of the composer dependency "joomla/utilities" is used.
The new version uses array_shift and not array_pop in file libraries/vendor/joomla/utilities/src/IpHelper.php, line 450, as you can see it here in the framework repository for the dependency's source:
https://github.com/joomla-framework/utilities/blob/2.0-dev/src/IpHelper.php#L450 .
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34380.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34380.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-05 12:57:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
|
||
Thanks! @richard67 can you also do a PR to update utilities in staging?
Thanks! @richard67 can you also do a PR to update utilities in staging?
@wilsonge Will do that.
I have tested this item✅ successfully on f29d596
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34380.