[#34323] - [4] Change notefield form field to display better
- Fixed in Code Base
- 3 Jun 2021
- Medium
- Build: 4.0-dev
- # 34323
- Diff
- PhilETaylor:alertsnotes
User tests: Successful: Unsuccessful:
Pull Request for Issue #34247
Summary of Changes
correct rendering of alerts
Testing Instructions
Visit Joomla API Token tab in Edit User and look at the alert blocks which are yellow - these are built by a "note" field in a form.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Text color is addressed in #34328
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Labels |
Added:
?
|
||
Such as?
There are only 4 uses. This one in Joomla API token.
The one in template details which is still ok:
The one in Global Config which now has an icon which looks better:
and lastly in the TinyMCE Plugin edit page which again looks fine to me:
I have tested this item
That alert colour is difficult to read or it is my old eyes!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34323.
I am not in favour of the change to the markup here.
But yet you dont state what would actually pass your own personal test... almost as bad as down thumbing.
Ok, Ill remove the icon, but leave the rest as that allows correct markup without a p tag in alerts
| Category | Libraries Front End Plugins | ⇒ | Front End Plugins |
Ah I see the problem now. The clue was checking the other uses.
The heading element is valid and its used for the LABEL
The DESCRIPTION is displayed in a div. no p tags or anything.
The Mistake in this plugin is that label="PLG_USER_TOKEN_SAVEME_DESC" should be description="PLG_USER_TOKEN_SAVEME_DESC"
PR Description/intro changed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34323.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34323.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34323.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-03 16:42:16 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks!
This pr is not correct as it doesn't take into account all the other uses of this field type