[#34253] - [3.10] Handle the removal of the FTP support from Joomla 4 for com_joomlaupdate
- Fixed in Code Base
- 30 May 2021
- Medium
- Build: 3.10-dev
- # 34253
- Diff
- zero-24:ftp_to_4
User tests: Successful: Unsuccessful:
Summary of Changes
Handle the removal of the FTP support from Joomla 4 for com_joomlaupdate. At the time of the upload we can just add a message given that we dont know the version you are updating to at this point.
Testing Instructions
- Install 3.10
- point to an Joomla 4 package
- extra: please make sure that on 3.x the option will be showed correctly
Actual result BEFORE applying this Pull Request
You still have the FTP options
Expected result AFTER applying this Pull Request
The FTP options are gone
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings JavaScript |
| Labels |
Added:
?
?
|
||
I have tested this item
After patch applied the red marked Installation method isn't available:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
As this PR here has 2 successful tests I wanted to set it RTC.
But there is something I don't understand.
When reading the code, the version compare here results in true if the first argument is greater or equal (because operator is '>=") than the second, and otherwise false, see PHP docs here: https://www.php.net/manual/en/function.version-compare.php
But I have just tested that the PR works like it should work and as it is described, and so it work vice versa than I would expect when reading the code.
I see 2 possible explanations for that:
- I understand something completely wrong or am blind, or
- The version compare at that place and also the search for an update has problems with our extra versions like "beta8-dev" which are part of the current version when testing on a current 3.10-dev branch or a 3.10 nightly build and also part of the update version when using the custom URL of the nightly builds.
Can someone else check and help me out?
I am exactly the same as you @richard67 that's why I installed it to test because I was sure it was wrong ;)
I'd still like to understand why it works or where I am wrong.
I have tested this item
When using current 3.10-dev branch or a current 3.10 nightly, which both have an extra version, and you use the custom update URLs for nightlies of 3.10 or 4.0 for testing, then this PR behaves as described, even if the version compare in the code is wrong.
But if you apply this patch to a 3.10 Alpha 4 and then attempt to update to Alpha 5, the method selection is not shown, but it should be.
When changing the version compare to "version_compare($this->updateInfo['latest'], '4.0.0', '<')", it still doesn't work as expected because the version compare seems to be confused by the extra versions.
When changing the version compare to "version_compare($this->updateInfo['latest'], '4', '<')", it works as expected. This is the same issue which we once had in the "Required PHP & Database Settings" to show the check for database supported only when updating to 4.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
Merged thanks
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
@sandramay0905 @brianteeman Could you test again if it still works for you? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-30 08:39:12 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
Removed: ? |
||
tks
I have tested this item✅ successfully on 1dd5d0a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34253.