[#34252] - Update composer and remove dummy random_compat
- Closed
- 29 May 2021
- Medium
- Build: 4.0-dev
- # 34252
- Diff
- zero-24:remove_dummy_random_compat
User tests: Successful: Unsuccessful:
Summary of Changes
Remove the dummy random_compat https://github.com/paragonie/random_compat#version-99999
Package operations: 0 installs, 19 updates, 0 removals
- Updating psr/link (1.0.0 => 1.1.1): Loading from cache
- Updating fig/link-util (1.1.2 => 1.2.0): Loading from cache
- Updating laminas/laminas-zendframework-bridge (1.1.1 => 1.2.0): Loading from cache
- Updating laminas/laminas-diactoros (2.4.1 => 2.6.0): Loading from cache
- Updating symfony/polyfill-php80 (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/polyfill-mbstring (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/var-dumper (v5.2.6 => v5.2.8): Loading from cache
- Updating symfony/polyfill-php72 (v1.22.1 => v1.23.0): Loading from cache
- Updating psr/log (1.1.3 => 1.1.4): Loading from cache
- Updating symfony/error-handler (v5.2.6 => v5.2.8): Loading from cache
- Updating symfony/polyfill-php73 (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/polyfill-ctype (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/yaml (v5.2.5 => v5.2.9): Loading from cache
- Updating symfony/polyfill-intl-normalizer (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/polyfill-intl-grapheme (v1.22.1 => v1.23.0): Loading from cache
- Updating symfony/string (v5.2.6 => v5.2.8): Loading from cache
- Updating symfony/polyfill-iconv (v1.22.1 => v1.23.0): Loading from cache
- Updating fgrosse/phpasn1 (v2.2.0 => v2.3.0): Loading from cache
- Updating symfony/console (v5.2.6 => v5.2.8): Loading from cache
Testing Instructions
install joomla
apply this patch
run composer install --no-dev (or use the generated package)
Make sure joomla still loads.
Actual result BEFORE applying this Pull Request
There is an empty random_compat package while the 9.99.9 version is empty and does nothing anyway.
Expected result AFTER applying this Pull Request
That package is gone and the other listed packages are updated.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
Looking at the original post I would expect to see it listed as removed but there were zero removals
Package operations: 0 installs, 19 updates, 0 removals
Unable to test as none of my installs contain this random_compat
Well i have just double checked the latest nightly build:
And when we check the package from the download section here random_compat is gone:
When you check the lib thats loaded there you see its empty as described in the docs linked above.
Looking at the original post I would expect to see it listed as removed but there were zero removals
Its clearly gone as you can see on my screenshots i dont know how that counter works within composer.
It looks like it is installed as its a required dependency of two packages (hence I didnt find it in composer.json and only in composer.lock)
Correct. IIRC its from joomla/session and sodium_compat. But with php7 as minimum its empty anyway.
and I see now that replace command just prevents the dependency being loaded
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34252.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34252.
Sorry - my test results were just local checking that the removal of random_compat worked
I did not check the updates which is where drone is producing the errors as they are php 8
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34252.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 01:47:55 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
|
||
Unable to test as none of my installs contain this random_compat