[#34178] - [4.0] Pass value to language string
- Fixed in Code Base
- 25 May 2021
- Medium
- Build: 4.0-dev
- # 34178
- Diff
- Quy:gd-iconv-intl
User tests: Successful: Unsuccessful:
Summary of Changes
Pass value to language string instead of hard-coding in template.
Testing Instructions
Go to System > System Information
Click PHP Settings tab.
Labels same before/after PR.
GD Available
iconv Available
intl Available
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings |
It was deliberate that the strings were written this way to avoid the situation where translators try to translate the gd, iconv and intl
Please do not do this
Won't this be an issue with RTL if not done this way?
no - why
Translators won't see these values in the language string to translate because before/after PR these values are in the template vs, the following where they might.
COM_ADMIN_XML_ENABLED="XML فعال"
COM_ADMIN_ZLIB_ENABLED="Zlib فعال"
we dont want them to see the strings. they will try to translate them. we saw that for years with the "installation" folder being translated etc etc.
This PR is wrong
Have you looked at the code? Sorry if my description gave you the wrong impression.
Sorry you are right your description gives the wrong impression completely
| Title |
|
||||||
Updated title/description. Sorry for the confusion.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34178.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34178.
@brianteeman Could you revert your thumbs down on the PR description? It looks so ... sharkyesque
also didnt help that I was checking the code locally for the update model where it was already a sprintf
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-25 07:12:23 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 2cf7718
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34178.