NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
24 May 2021

Pull Request is supplamentary to #33724

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 24 May 2021
avatar dgrammatiko dgrammatiko - change - 24 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2021
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 24 May 2021
Labels Added: NPM Resource Changed ?
avatar richard67 richard67 - test_item - 24 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 24 May 2021

I have tested this item successfully on 5252057

I've tested with success as follows:

  1. Applied the patch from PR #33724 and installed the dropbox plugin as described there in testing instructions.
  2. Removed the guzzlehttp folder from the plugin's vendor folder as described here, so that the one shipped with the CMS is used, to work around the issue linked in that comment, too: #33724 (comment) .
  3. Inserted an image into an article, using an image from the Dropbox.
    Result: See #33724 (comment) .
  4. Applied the patch of this PR.
  5. Repeated step 3 a few times with different images:
    Result: Image is visible, and the tag has the height and width attributes equal to height and width of the image.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.
avatar richard67
richard67 - comment - 24 May 2021

@chmst Could you test this PR as desribed in my test result above?

It's the same test you already have done for @joomdonation 's PR with the external Dropbox adapter.

First check if it has your issue, then apply the patch of this PR here, too, run npm ci and check again.

For me it worked.

avatar chmst chmst - test_item - 26 May 2021 - Tested successfully
avatar chmst
chmst - comment - 26 May 2021

I have tested this item successfully on 5252057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.

avatar richard67 richard67 - change - 26 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.

avatar dgrammatiko
dgrammatiko - comment - 26 May 2021

Please DO NOT merge this BEFORE #33724

avatar richard67
richard67 - comment - 26 May 2021

@dgrammatiko The other PR has been merged now. Could you solve here the conflict resulting from that?

avatar dgrammatiko dgrammatiko - change - 26 May 2021
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 26 May 2021 - richard67: Tested successfully
avatar richard67 richard67 - alter_testresult - 26 May 2021 - chmst: Tested successfully
avatar richard67
richard67 - comment - 26 May 2021

Previous tests and RTC are still valid since the one commit after the tests was a clean branch update. In addition I have repeated my test with the same result as before, success.

avatar rdeutz rdeutz - close - 26 May 2021
avatar rdeutz rdeutz - merge - 26 May 2021
avatar rdeutz rdeutz - change - 26 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-26 13:14:53
Closed_By rdeutz
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment