? ? Pending

User tests: Successful: Unsuccessful:

avatar simbus82
simbus82
24 May 2021

Summary of Changes

Found a little typo in $setting->label (row 223) for the new check about intl.

Probably the little mistake was introduced with this PR #33977

avatar simbus82 simbus82 - open - 24 May 2021
avatar simbus82 simbus82 - change - 24 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2021
Category Installation
avatar brianteeman
brianteeman - comment - 24 May 2021

Please test 34180

avatar simbus82 simbus82 - change - 24 May 2021
The description was changed
avatar simbus82 simbus82 - edited - 24 May 2021
avatar simbus82
simbus82 - comment - 24 May 2021

Please test 34180

Sure, it works perfectly, it's the same correction I proposed in this PR ?

avatar brianteeman
brianteeman - comment - 24 May 2021

standard text ;)

Please close this here and record a successful test on the pr

avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

LOL @brianteeman your PR was 2 mins after this guy :)

avatar richard67 richard67 - test_item - 24 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 24 May 2021

I have tested this item successfully on df47ed1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34179.

avatar PhilETaylor PhilETaylor - test_item - 24 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

I have tested this item successfully on df47ed1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34179.

avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

I have tested this item successfully on df47ed1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34179.

avatar brianteeman
brianteeman - comment - 24 May 2021

@PhilETaylor sorry it was so slow

avatar richard67 richard67 - change - 24 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 24 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34179.

avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

@PhilETaylor sorry it was so slow

You seem to be very confused.

What really happened is that you read this PR and thought it was an issue.

As evidenced by your sentence.

Pull Request for Issue #34179

You deliberately duplicated someone else's PR after they submitted it, and then demanded they test yours and close theirs... thinking theirs was an issue and not a PR.

avatar brianteeman
brianteeman - comment - 24 May 2021

yes i am very confused - its been a very long day - i read this as an issue not a pr.

time for a cold shower

avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

No worries ...

avatar Quy Quy - change - 24 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-24 18:22:33
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 24 May 2021
avatar Quy Quy - merge - 24 May 2021
avatar Quy
Quy - comment - 24 May 2021

Thank you!

avatar simbus82
simbus82 - comment - 25 May 2021

Thank you guys!

Add a Comment

Login with GitHub to post a comment