[#34158] - [4.0] Sidebar collapse toggle incorrectly initialized for smaller screens
- Closed
- 24 May 2021
- Medium
- Build: 4.0-dev
- # 34158
- Diff
- eopws:sidebar-collapse-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #34117.
Summary of Changes
Page resize logic updated. Now the resize function called when page loaded in order to solve whether the menu should be collapsed or not (according to aria-expanded="false" on mobile the menu should be collapsed initially).
Testing Instructions
- Visit the Global Configuration page in the Backend.
- Switch to the mobile view using Devtools.
- Refresh the page while being in the mobile view or navigate outside and back to this page to imitate how a mobile user would enter this page.
- Notice that the sidebar dropdown is initially collapsed (Contrary to the previous behaviour) and when you press the toggle button animation is ok contrary to the previous behaviour.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Added the resizeAction function and a comment to it. Please comment if documentation is incorrect (e.g. english grammar)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 09:27:22 |
| Closed_By | ⇒ | eopws | |
| Labels |
Added:
NPM Resource Changed
?
|
||
@dgrammatiko
Maybe I am wrong, but it seems that the #33877 PR doesn't solve the #34117 issue problem ・_・
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-05-24 09:27:22 | ⇒ | |
| Closed_By | eopws | ⇒ |
| Status | New | ⇒ | Pending |
doesn't solve the #34117 issue problem
Of course, it doesn't because the template CANNOT and SHOULD NOT interfere with specific page/component behaviours. This PR is totally wrong, you're deferring a responsibility of a specific page to the template, that's not how things should work...
This PR is totally wrong, you're deferring a responsibility of a specific page to the template, that's not how things should work...
Not at all, the logic of this PR is to call 'resize' function when a page loads.
Please close it, it's wrong...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 10:09:23 |
| Closed_By | ⇒ | eopws |
using dev-tools with mobile preview turned on
Try to use real mobile size, not the emulation...
Try to use real mobile size, not the emulation...
I'm currently not able to. Hope it works.
Probably it is a dev-tools's bad =)
Please undo the changes here there's a PR already: #33877