NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 May 2021

On a multilingual site there is a badge for the default language menu item. This is failing the contrast checks.

this is an scss change so dont forget to rebuild the css for testing

image

avatar brianteeman brianteeman - open - 24 May 2021
avatar brianteeman brianteeman - change - 24 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2021
Category Administration Templates (admin) NPM Change
avatar infograf768
infograf768 - comment - 24 May 2021

Suggest also adding a white border as the background would not stand much vs the sidebar background color.

background-color: var(--atum-bg-dark-60);
border: 1px solid white;

which would give

Screen Shot 2021-05-24 at 10 29 02

instead of this with this pr

Screen Shot 2021-05-24 at 10 32 16

avatar brianteeman
brianteeman - comment - 24 May 2021

Not required for accessibility. That's a styling change which is beyond the scope of this pr and should be considered as a separate issue as it would impact the consistency of badge styling elsewhere

avatar infograf768
infograf768 - comment - 24 May 2021

should be considered as a separate issue as it would impact the consistency of badge styling elsewhere

I doubt about that. main-nav is only used by the admin mod_menu.

css is in _sidebar.scss

// Sidebar navigation
.main-nav {

[...]

.badge {
    align-self: center;
    margin: 0 .3rem .25rem;
    background-color: var(--atum-bg-dark-50);
  }

Just say you don't want to do the change in a a11y PR. That's enough.

avatar brianteeman
brianteeman - comment - 24 May 2021

I meant consistency with badges everywhere not just sidebar.

avatar eopws
eopws - comment - 24 May 2021

Maybe out of topic, but why duplicate language tag?

avatar infograf768
infograf768 - comment - 24 May 2021

Maybe out of topic, but why duplicate language tag?

It is not a duplicate. The tag added to the menu title comes from the multilingual sample data and it is there on purpose.
On a real site it is not necessary.

avatar wilsonge wilsonge - change - 24 May 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-24 16:09:41
Closed_By wilsonge
Labels Added: NPM Resource Changed ? ?
avatar wilsonge wilsonge - close - 24 May 2021
avatar wilsonge wilsonge - merge - 24 May 2021
avatar wilsonge
wilsonge - comment - 24 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 24 May 2021

thank you

Add a Comment

Login with GitHub to post a comment