User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
Not required for accessibility. That's a styling change which is beyond the scope of this pr and should be considered as a separate issue as it would impact the consistency of badge styling elsewhere
should be considered as a separate issue as it would impact the consistency of badge styling elsewhere
I doubt about that. main-nav
is only used by the admin mod_menu.
css is in _sidebar.scss
// Sidebar navigation
.main-nav {
[...]
.badge {
align-self: center;
margin: 0 .3rem .25rem;
background-color: var(--atum-bg-dark-50);
}
Just say you don't want to do the change in a a11y PR. That's enough.
I meant consistency with badges everywhere not just sidebar.
Maybe out of topic, but why duplicate language tag?
Maybe out of topic, but why duplicate language tag?
It is not a duplicate. The tag added to the menu title comes from the multilingual sample data and it is there on purpose.
On a real site it is not necessary.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 16:09:41 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
NPM Resource Changed
?
?
|
Thanks!
thank you
Suggest also adding a white border as the background would not stand much vs the sidebar background color.
which would give
instead of this with this pr