[#34156] - [4.0] gray-600 [a11y]
- Fixed in Code Base
- 25 May 2021
- Medium
- Build: 4.0-dev
- # 34156
- Diff
- brianteeman:mon4
User tests: Successful: Unsuccessful:
Anything using $gray-600 is getting the color from the bs5 variables.scss
$text-muted: $gray-600 !default;
$form-text-color: $text-muted !default;
This is not a contrast problem when the background color is white but if the background is the blue pattern then the color ratio fails
One place where this is used is the alias description
I am not sure why but we are overriding the bs5 default colors for the $gray-* variables nor why the $gray-600 was commented out
This PR uncomments the gray-600 variable and changes it slightly so that the contrast is valid on both the white and blue backgrounds
Pull Request for Issue #33580
this is a scss change so dont forget to rebuild the css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34156.
I literally cannot see any difference in the colour - am I tool old now?
You shouldn't be able to unless you have great eyesight. it only fractionally failed the contrast checker but people want to have zero errors when they run a test
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34156.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34156.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-25 20:35:08 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
thanks
I literally cannot see any difference in the colour - am I too old now?
Before PR #6c757d
After PR #666e76
EDIT: ok maybe I can see a difference here in GitHub in these images now, but in the browser I could not...