User tests: Successful: Unsuccessful:
Pull Request for Issue #33480 and #34081.
Added the logic of addin' horizontal scrollbar to grid form when not havin' enough width for elements
Create a menu item of "Category Blog" type and go to the "Blog Layout" tab
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
Title |
|
Sorry, no, Horizontal scrolling is not responsive. The line must break, as it does on smaller devices.
Ok, I'm gonna fix it
Through few hours of searchin the only one solution that I found is to reduce count of columns, but I'm not sure if it is a good architecture solution (change layout of the whole template in order to make one page look better?)...
I would love to see a comment from a more experienced developer than me...
Should this pull request get a test?
I have tested this item
Thanks for the hint @drmenzelit at #34450 (comment)
Sorry for missing.
According to this issue #34450 it's okay to add horizontal scroll.
But according to this comment #34145 (comment) it's better to break line.
So which is better?
Through few hours of searchin the only one solution that I found is to reduce count of columns, but I'm not sure if it is a good architecture solution (change layout of the whole template in order to make one page look better?)...
I would love to see a comment from a more experienced developer than me...
This is the better solution
Labels |
Added:
NPM Resource Changed
?
|
I think the problem is more complex than the fix .
You changed:
` @include media-breakpoint-up(md) {
grid-template-columns: repeat(4, 1fr);
grid-gap: 1rem 2rem;
}
'
from 4 to 2 columns. But what is width the larger one. This view is broken as well
@include media-breakpoint-up(lg) {
--span-5: span 5;
grid-template-columns: repeat(6, 1fr);
}
The leading-Class column is problem because it goes over two grid column.
@ciar4n , can you take a look please.
I added a PR which I think addresses the same issue as this PR. Please toke a look at my PR an see it id addresses the issue and if it is fixed? #35823. If so, then we can close this PR.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-19 09:52:33 |
Closed_By | ⇒ | eopws | |
Labels |
Added:
?
?
Removed: ? |
Sorry, no, Horizontal scrolling is not responsive. The line must break, as it does on smaller devices.