? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
23 May 2021

Summary of Changes

When enabling language debug mode in Joomla 4.0, the new Module Empty State would display untranslated strings as it was doing a comparison incorrectly

Testing Instructions

Load home dashboard - view empty states in modules
enable language debug in joomla global config.
Load home dashboard - view empty states in modules

Actual result BEFORE applying this Pull Request

Screenshot 2021-05-23 at 16 56 38

Expected result AFTER applying this Pull Request

Screenshot 2021-05-23 at 17 12 33

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 23 May 2021
avatar PhilETaylor PhilETaylor - change - 23 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2021
Category Layout
avatar sandramay0905 sandramay0905 - test_item - 24 May 2021 - Tested unsuccessfully
avatar sandramay0905
sandramay0905 - comment - 24 May 2021

I have tested this item ? unsuccessfully on d6fe338

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34144.
avatar PhilETaylor PhilETaylor - change - 24 May 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 24 May 2021

Thanks - very strange as I normally have error reporting set to maximum. I have now fixed this.

avatar sandramay0905 sandramay0905 - test_item - 24 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 24 May 2021

I have tested this item successfully on c062dfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34144.

avatar richard67 richard67 - test_item - 24 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 24 May 2021

I have tested this item successfully on c062dfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34144.

avatar richard67 richard67 - change - 24 May 2021
The description was changed
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 24 May 2021
avatar richard67
richard67 - comment - 24 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34144.

avatar Quy Quy - close - 24 May 2021
avatar Quy Quy - merge - 24 May 2021
avatar Quy Quy - change - 24 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-24 14:37:16
Closed_By Quy
Labels Added: ?
avatar Quy
Quy - comment - 24 May 2021

Thank you!

Add a Comment

Login with GitHub to post a comment