[#34146] - [4.0] atum Toolbar items sizing issue
- Fixed in Code Base
- 27 May 2021
- Medium
- Build: 4.0-dev
- # 34146
- Diff
- himanshu007-creator:sameSize
User tests: Successful: Unsuccessful:
Pull Request for Issue #34109 .
Summary of Changes
On enabling Highlight Links in accessibility, there was mismatch in size of toolbar items because of additional padding.
But keeping accessibility in mind, other things should be left unchanged, therefore just removed the padding.
Testing Instructions
- apply the patch and rebuild css
npm run build:css - turn highlight links on from accessibility and note, size doesnt change
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@PhilETaylor made the changes as suggested by you.
Looks good - thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @himanshu007-creator Could you implement @Quy 's suggestion? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
| Labels |
Added:
?
|
||
Made the changes @richard67
| Labels |
Removed:
?
|
||
I have tested this item
After update J4 using custom update server of prebuild package:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34146.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-27 13:04:22 |
| Closed_By | ⇒ | Quy |
Thanks!
I think you misunderstood the issue.
The issue is
the User Menu oval background is not the same height and depth as the other two (Postinstallation messages and joomla4 in your screenshot)
User Menu is not underlined.