? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
22 May 2021

Summary of Changes

The $table->load check for deleting group rows has been moved above the loop that deletes them.
Please refer to #33771 for the reason behind this.
This PR mimics what was done for Content Map's Delete All Bug (#33771) to User Groups where a similar bug was left un-noticed

Testing Instructions

  1. Visit Backend -> Users -> User Groups
  2. Add 4 new groups where 2 groups are the parent and 2 are their child:
- B
:  - B1
- C
:  - C1
  1. Select all of these items as shown in the gif below. Order is Important: Parent (B) -> It's Child (B1) -> Parent (C) -> It's Child (C1)
  2. Proceed to Delete them

Before the PR: only the first Parent-Child pair would be deleted and the 2nd Parent-Child was skipped. This happened because the B1 was deleted with B (it's parent) and the loop returned false when it iterated over B1 as it was no longer present in the table.
After the PR: all selected groups will be deleted.

Actual result BEFORE applying this Pull Request

delGroupsBefore

Expected result AFTER applying this Pull Request

delGroupsAfter

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 22 May 2021
avatar YatharthVyas YatharthVyas - change - 22 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Administration com_users
avatar ChristineWk ChristineWk - test_item - 22 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 22 May 2021

I have tested this item successfully on 79ad657


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34094.

avatar sandramay0905 sandramay0905 - test_item - 23 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 23 May 2021

I have tested this item successfully on 79ad657


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34094.

avatar chmst chmst - change - 23 May 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 23 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34094.

avatar Quy Quy - close - 23 May 2021
avatar Quy Quy - merge - 23 May 2021
avatar Quy Quy - change - 23 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-23 13:12:27
Closed_By Quy
Labels Added: ? ?
avatar Quy
Quy - comment - 23 May 2021

Thanks!

avatar YatharthVyas
YatharthVyas - comment - 23 May 2021

Thank you

avatar Quy
Quy - comment - 23 May 2021

Is #19346 for J3 related? Maybe you can do a PR for it. Thanks!

Add a Comment

Login with GitHub to post a comment