? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 May 2021

Pull Request for Issue #33179.

Summary of Changes

This PR address the issue #33179 . So please see #33179 to understand the issue which this PR tries to solves

Testing Instructions

  1. Prepare an image with file extension in filename in upper case. For example sample.PNG
  2. Copy that file to templates/cassiopeia folder
  3. Go to System -> Site Templates -> Cassiopeia Details and Files to see files/folder from that template
  4. Before patch: You won't see the file sample.PNG
  5. After patch, you will see the file
avatar joomdonation joomdonation - open - 22 May 2021
avatar joomdonation joomdonation - change - 22 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Administration com_templates
avatar brianteeman
brianteeman - comment - 22 May 2021

It works but it only addresses half the issue so that shouldnt be closed

avatar joomdonation
joomdonation - comment - 22 May 2021

@brianteeman It addresses that issue. In the original issue, the file can still be uploaded, it is just invisible. The issue which you got yesterday (could not upload file with upper case characters when iconv is available) is different. But I will try to look at that too.

avatar jwaisner
jwaisner - comment - 23 May 2021

@joomdonation , just tested. While the file does appear now it, the preview/editor space does not appear when editing a file where the extension is uppercase. That may be out of scope for this as it looks like the original reported an issue uploading the file at all. Marking a successful test.

avatar jwaisner jwaisner - test_item - 23 May 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 23 May 2021

I have tested this item successfully on 3437057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34095.

avatar sandramay0905 sandramay0905 - test_item - 23 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 23 May 2021

I have tested this item successfully on 3437057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34095.

avatar richard67 richard67 - change - 23 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 23 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34095.

avatar chmst chmst - change - 23 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-23 16:47:02
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 23 May 2021
avatar chmst chmst - merge - 23 May 2021
avatar chmst
chmst - comment - 23 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment