Feeling Lucky
?
[#34090] - [4.0] Use setDocumentTitle for com_finder
- Fixed in Code Base
- 22 May 2021
- Medium
- Build: 4.0-dev
- # 34090
- Diff
- joomdonation:com_finder_setDocumentTitle
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
A small code clean up to Form view of com_contact component. The parent class has method setDocumentTitle https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/MVC/View/HtmlView.php#L607 to calculate and set page title base on Site Name in Page Titles setting in Global Configuration already, so we do not have to write the same code again in the child class.
Testing Instructions
- Code review should be enough
- Or :
- Create a menu item to link to Search menu item type of Smart Search component
- Go to frontend of the site using, access to that menu item and make sure browser page title is the same with before.
- Go to System -> Global Configuration, navigate to Site tab, try to change the value of Site Name in Page Titles config option (see attached screenshot), then access to the menu item above again, confirm that browser page title is changed according to the value of that config option.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
sandramay0905
- comment
- 22 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34090.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 22 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34090.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-22 07:55:19 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 22 May 2021
Thanks!
I have tested this item✅ successfully on acb06ac
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34090.