Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34089] - [4.0] Use setDocumentTitle for com_wrapper

? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 May 2021

Pull Request for Issue # .

Summary of Changes

A small code clean up to Form view of com_wrapper component. The parent class has method setDocumentTitle https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/MVC/View/HtmlView.php#L607 to calculate and set page title base on Site Name in Page Titles setting in Global Configuration already, so we do not have to write the same code again in the child class.

Testing Instructions

  1. Code review should be enough
  2. Or :
  • Create a menu item to link to Iframe Wrapper menu item type of Wrapper component
  • Go to frontend of your site, access to that menu item and make sure browser page title is the same with before.
  • Go to System -> Global Configuration, navigate to Site tab, try to change the value of Site Name in Page Titles config option (see attached screenshot), then access to the menu item above again, confirm that browser page title is changed according to the value of that config option.

sitename_in_page_title

avatar joomdonation joomdonation - open - 22 May 2021
avatar joomdonation joomdonation - change - 22 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category ⇒ Front End com_wrapper
avatar chmst chmst - test_item - 22 May 2021 - Tested successfully
avatar chmst
chmst - comment - 22 May 2021

I have tested this item ✅ successfully on 69b91c7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34089.

avatar alikon alikon - test_item - 22 May 2021 - Tested successfully
avatar alikon
alikon - comment - 22 May 2021

I have tested this item ✅ successfully on 69b91c7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34089.

avatar alikon alikon - change - 22 May 2021
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 22 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34089.

avatar sandramay0905 sandramay0905 - test_item - 22 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 22 May 2021

I have tested this item ✅ successfully on 69b91c7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34089.

avatar richard67 richard67 - change - 22 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-22 07:54:56
Closed_By ⇒ richard67
Labels Added: ?
avatar richard67 richard67 - close - 22 May 2021
avatar richard67 richard67 - merge - 22 May 2021
avatar richard67
richard67 - comment - 22 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment