? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 May 2021

Pull Request for Issue #31249 and #33183 .

Summary of Changes

Move GroupedlistField::getInput() to the layout.
Available 2 layout:

joomla.form.field.groupedlist - default, a regular select input
joomla.form.field.groupedlist-fancy-select - optional, fancy select

Testing Instructions

Create 2 field, with different layout, somewhere:

<field
  name="field0" type="templatestyle" label="Field 0"
  multiple="multiple"
/>

<field
  name="field1" type="menuitem" label="Field 1"
  multiple="multiple"
  layout="joomla.form.field.groupedlist-fancy-select"
/>

Actual result BEFORE applying this Pull Request

Both fields will show default <select> input

Expected result AFTER applying this Pull Request

First field will be default <select> input
Second field will be "fancy select"

Documentation Changes Required

Yes, update doc about Groupedlist field.

avatar Fedik Fedik - open - 22 May 2021
avatar Fedik Fedik - change - 22 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Layout Libraries Front End Plugins
avatar Kostelano Kostelano - test_item - 22 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 22 May 2021

I have tested this item successfully on a6916f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34091.

avatar Fedik Fedik - change - 22 May 2021
Labels Added: ?
avatar YatharthVyas YatharthVyas - test_item - 22 May 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 22 May 2021

I have tested this item successfully on 53f8dba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34091.

avatar richard67 richard67 - alter_testresult - 24 May 2021 - Kostelano: Tested successfully
avatar richard67
richard67 - comment - 24 May 2021

The test result from @Kostelano is still valid since the change after that was only code style with spaces and the year in the copyright statements.

avatar richard67 richard67 - change - 24 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34091.

avatar chmst chmst - change - 25 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-25 20:43:40
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 25 May 2021
avatar chmst chmst - merge - 25 May 2021
avatar chmst
chmst - comment - 25 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment