[#34060] - [4] Delete whole method from class as it contains calls to methods that dont exist.
- Fixed in Code Base
- 26 May 2021
- Medium
- Build: 4.0-dev
- # 34060
- Diff
- PhilETaylor:unusedarchivemodelmethod
User tests: Successful: Unsuccessful:
Code review.
Not a typo.
This method cannot be used - as _buildQuery method doesnt even exist.
I do not believe this method is ever called, and after considerable testing I cannot locate any code or gui interface that would call it.
Happy to be proved wrong, but even if something did call it, they would get a PHP error because _buildQuery method doesnt exist as a string in the whole of a Joomla 4 site.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
rdeutz
- | Title |
|
||||||
How do you think about remove _getList method from same class, too ? There is no reason we have to override that method like we are doing at the moment. I would vote to take this change to remove the method before 4.0 release.
If they are generically all the same and there is a parent method that does the same thing then they should be removed.
I would say though that that should be a different PR. This PR is focused on a method that clearly cannot ever be used as the _buildQuery method doesnt exist anywhere in code, so would cause a PHP Fatal error if this code was ever used and so its very obvious that this method has not been called in its current state for many years and can be removed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34060.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34060.
from same class, too
Ah I missed that you mean "this class", the one I changed. Yes it looks odd having a odd setting, that can be done in the view if it was actually needed. (Hint: its not needed)
@PhilETaylor Maybe a different PR. Sometime, we have strange code in our codebase. For now, this PR is RTC.
@PhilETaylor Maybe a different PR. Sometime, we have strange code in our codebase. For now, this PR is RTC.
This is #34118
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-26 19:38:25 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
Thanks!
I have tested this item✅ successfully on 127e4a7
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34060.