NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 May 2021

Pull Request for Issue #33792

Go to Control Panel -- Menus -- Manage (panel on the right). Click on any of the modules. A drop-down item on hover has no rounding of its borders.

this is a css change so npm run build:css

Before

image

After

image

avatar brianteeman brianteeman - open - 20 May 2021
avatar brianteeman brianteeman - change - 20 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Administration Templates (admin) NPM Change
avatar ChristineWk ChristineWk - test_item - 20 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 May 2021

I have tested this item successfully on e99f5eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34059.

avatar Kostelano Kostelano - test_item - 21 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 21 May 2021

I have tested this item successfully on e99f5eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34059.

avatar richard67 richard67 - change - 21 May 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 21 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34059.

avatar PhilETaylor
PhilETaylor - comment - 21 May 2021

Must be browser specific as safari on Mac doesnt have this issue before this PR

Before PR

Screenshot 2021-05-21 at 11 23 43

After PR

Screenshot 2021-05-21 at 11 26 13

avatar Kostelano
Kostelano - comment - 21 May 2021

@PhilETaylor hover over the drop-down item.

avatar PhilETaylor
PhilETaylor - comment - 21 May 2021

ah I missed that - in that case - yes, safari on Mac had this issue and this PR fixed it.

Screenshot 2021-05-21 at 11 31 02

avatar chmst chmst - close - 21 May 2021
avatar chmst chmst - merge - 21 May 2021
avatar chmst chmst - change - 21 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-21 21:23:46
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 21 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 21 May 2021

thanks - learnt a lot fixing that one

Add a Comment

Login with GitHub to post a comment